Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

libzfs_sendrecv: Style pass on dump_filesystems 

* Add a high level comment.
* Eliminate unnecessarily void arg.
* Capitalize and punctuate complete sentences in comments.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes #12967
This commit is contained in:
Ryan Moeller 2021-08-18 21:01:21 +00:00 committed by Brian Behlendorf
parent 1910a30848
commit 45932229d5
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/libzfs/libzfs_sendrecv.c
View File

@ -1270,10 +1270,12 @@ dump_filesystem(zfs_handle_t *zhp, send_dump_data_t *sdd)
return (rv); return (rv);
} }
/*
* Send all snapshots for all filesystems in sdd.
*/
static int static int
dump_filesystems(zfs_handle_t *rzhp, void *arg) dump_filesystems(zfs_handle_t *rzhp, send_dump_data_t *sdd)
{ {
send_dump_data_t *sdd = arg;
nvpair_t *fspair; nvpair_t *fspair;
boolean_t needagain, progress; boolean_t needagain, progress;
@ -1326,7 +1328,7 @@ again:
if (parent_guid != 0) { if (parent_guid != 0) {
parent_nv = fsavl_find(sdd->fsavl, parent_guid, NULL); parent_nv = fsavl_find(sdd->fsavl, parent_guid, NULL);
if (!nvlist_exists(parent_nv, "sent")) { if (!nvlist_exists(parent_nv, "sent")) {
/* parent has not been sent; skip this one */ /* Parent has not been sent; skip this one. */
needagain = B_TRUE; needagain = B_TRUE;
continue; continue;
} }
@ -1338,7 +1340,7 @@ again:
if (origin_nv != NULL && if (origin_nv != NULL &&
!nvlist_exists(origin_nv, "sent")) { !nvlist_exists(origin_nv, "sent")) {
/* /*
* origin has not been sent yet; * Origin has not been sent yet;
* skip this clone. * skip this clone.
*/ */
needagain = B_TRUE; needagain = B_TRUE;
@ -1361,7 +1363,7 @@ again:
goto again; goto again;
} }
/* clean out the sent flags in case we reuse this fss */ /* Clean out the sent flags in case we reuse this fss. */
for (fspair = nvlist_next_nvpair(sdd->fss, NULL); fspair; for (fspair = nvlist_next_nvpair(sdd->fss, NULL); fspair;
fspair = nvlist_next_nvpair(sdd->fss, fspair)) { fspair = nvlist_next_nvpair(sdd->fss, fspair)) {
nvlist_t *fslist; nvlist_t *fslist;