OpenZFS on Linux and FreeBSD
Go to file
Brian Behlendorf a4831fa023 Fix zvol_open() lock inversion
When restructuring the zvol_open() logic for the Linux 5.13 kernel
a lock inversion was accidentally introduced.  In the updated code
the spa_namespace_lock is now taken before the zv_suspend_lock
allowing the following scenario to occur:

    down_read <=== waiting for zv_suspend_lock
    zvol_open <=== holds spa_namespace_lock
    __blkdev_get
    blkdev_get_by_dev
    blkdev_open
    ...

     mutex_lock <== waiting for spa_namespace_lock
     spa_open_common
     spa_open
     dsl_pool_hold
     dmu_objset_hold_flags
     dmu_objset_hold
     dsl_prop_get
     dsl_prop_get_integer
     zvol_create_minor
     dmu_recv_end
     zfs_ioc_recv_impl <=== holds zv_suspend_lock via zvol_suspend()
     zfs_ioc_recv
     ...

This commit resolves the issue by moving the acquisition of the
spa_namespace_lock back to after the zv_suspend_lock which restores
the original ordering.

Additionally, as part of this change the error exit paths were
simplified where possible.

Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #12863
2021-12-22 09:31:58 -08:00
.github Strip colons from all test result filenames 2021-12-06 13:41:04 -08:00
cmd zed: Control NVMe fault LEDs 2021-11-12 16:31:55 -08:00
config Linux 5.16: The blk-cgroup.h header is where struct blkcg_gq is defined 2021-12-07 13:15:12 -08:00
contrib gcc 11 cleanup 2021-11-12 15:24:36 -08:00
etc zfs-import-{cache,scan}: change condition to FileNotEmpty 2021-02-05 11:42:40 -08:00
include Linux 5.16 compat: asm/fpu/xcr.h is new location for xgetbv/xsetbv 2021-12-07 13:15:11 -08:00
lib Update ABIs for zfs-2.0.7 2021-11-12 16:38:16 -08:00
man FreeBSD: Implement xattr=sa 2021-12-13 12:22:11 -08:00
module Fix zvol_open() lock inversion 2021-12-22 09:31:58 -08:00
rpm Correct a flaw in the Python 3 version checking 2021-11-12 15:24:36 -08:00
scripts Add zfs-test facility to automatically rerun failing tests 2021-12-06 13:40:48 -08:00
tests ZTS: import_rewind_device_replaced reliably fails 2021-12-08 15:01:44 -08:00
udev Centralize variable substitution 2020-07-14 17:33:44 -07:00
.editorconfig Add an .editorconfig; document git whitespace settings 2020-01-27 13:32:52 -08:00
.gitignore Add FreeBSD support to OpenZFS 2020-04-14 11:36:28 -07:00
.gitmodules Add zimport.sh compatibility test script 2014-02-21 12:10:31 -08:00
AUTHORS Add zstd support to zfs 2020-08-20 10:30:06 -07:00
CODE_OF_CONDUCT.md Replace ZFS on Linux references with OpenZFS 2020-10-16 13:01:24 -07:00
COPYRIGHT Fix typos 2020-06-09 21:24:09 -07:00
LICENSE Update build system and packaging 2018-05-29 16:00:33 -07:00
META Linux 5.15 compat: META (#12824) 2021-12-07 17:03:37 -08:00
Makefile.am cppcheck: integrete cppcheck 2021-06-23 13:22:15 -07:00
NEWS Fix NEWS file 2020-08-27 16:07:01 -07:00
NOTICE Update build system and packaging 2018-05-29 16:00:33 -07:00
README.md docs: update README's installation link 2020-10-16 13:00:13 -07:00
TEST Remove CI builder customization from TEST 2020-03-16 10:46:03 -07:00
autogen.sh Cause autogen.sh to fail if autoreconf fails 2018-07-06 09:27:37 -07:00
configure.ac Fix lseek(SEEK_DATA/SEEK_HOLE) mmap consistency 2021-11-12 16:31:55 -08:00
copy-builtin Replace ZFS on Linux references with OpenZFS 2020-10-16 13:01:24 -07:00
zfs.release.in Move zfs.release generation to configure step 2012-07-12 12:22:51 -07:00

README.md

img

OpenZFS is an advanced file system and volume manager which was originally developed for Solaris and is now maintained by the OpenZFS community. This repository contains the code for running OpenZFS on Linux and FreeBSD.

codecov coverity

Official Resources

Installation

Full documentation for installing OpenZFS on your favorite operating system can be found at the Getting Started Page.

Contribute & Develop

We have a separate document with contribution guidelines.

We have a Code of Conduct.

Release

OpenZFS is released under a CDDL license. For more details see the NOTICE, LICENSE and COPYRIGHT files; UCRL-CODE-235197

Supported Kernels

  • The META file contains the officially recognized supported Linux kernel versions.
  • Supported FreeBSD versions are 12-STABLE and 13-CURRENT.