zfs/module
George Amanakis 87d93731e7 Avoid deadlock when removing L2ARC devices under I/O
In case we have I/O and try to remove an L2ARC device a deadlock might
occur. arc_read()->zio_read()->zfs_blkptr_verify() waits for SCL_VDEV
to be dropped while holding the hash_lock. However, spa_l2cache_load()
holds SCL_ALL and waits for the hash_lock in l2arc_evict().

Fix this by moving zfs_blkptr_verify() to the top top arc_read() before
the hash_lock is taken. Verify the block pointer and return a checksum
error if damaged rather than halting the system, by using
BLK_VERIFY_LOG instead of BLK_VERIFY_HALT.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Mark Maybee <mark.maybee@delphix.com>
Signed-off-by: George Amanakis <gamanakis@gmail.com>
Closes #12054
2021-06-23 13:22:15 -07:00
..
avl Links in Source Files 2020-09-03 16:17:18 -07:00
icp ICP: gcm: Allocate hash subkey table separately 2020-10-30 16:06:09 -07:00
lua cppcheck: integrete cppcheck 2021-06-23 13:22:15 -07:00
nvpair Links in Source Files 2020-09-03 16:17:18 -07:00
os Do not hash unlinked inodes 2021-06-23 13:22:15 -07:00
spl Cleanup linux module kbuild files 2020-06-10 09:24:15 -07:00
unicode Throw const on some strings 2020-10-16 12:55:56 -07:00
zcommon Fix AVX512BW Fletcher code on AVX512-but-not-BW machines 2021-06-23 13:22:14 -07:00
zfs Avoid deadlock when removing L2ARC devices under I/O 2021-06-23 13:22:15 -07:00
zstd Optimize locking checks in mempool allocator 2020-11-03 09:51:10 -08:00
.gitignore Cleanup linux module kbuild files 2020-06-10 09:24:15 -07:00
Kbuild.in Add zstd support to zfs 2020-08-20 10:30:06 -07:00
Makefile.bsd Restore FreeBSD resource usage accounting 2021-03-05 12:50:32 -08:00
Makefile.in cppcheck: integrete cppcheck 2021-06-23 13:22:15 -07:00