zfs/lib/libspl/include
Brian Behlendorf 615e289a57 Revert "Remove declarations in VERIFY3_IMPL to save stack"
This reverts commit 421d95b3ea.

Ricardo correctly pointed out that there is more going on here than
typecasting.  By removing the locals we are actually causing LEFT and
RIGHT to be evaluated twice which can potentially lead to some
strange side effects as:

1) VERIFY3*() causing a panic but in the panic message the values
look correct such that the assertion shouldn't fail, or:

2) if LEFT or RIGHT are expressions with side-effects (e.g. a call
to a function which changes some state), then when we panic and
examine the crash dump, it may lead to an unexpected state because
we are not expecting certain things to change during the panic,
after the expressions inside VERIFY3*(...) have been evaluated.

3) Also, it may lead to double-panics or deadlocks during panics,
like for example, if the expressions inside VERIFY3*(...) only expect
to be called once (e.g. because they acquire a mutex).
2010-08-06 11:08:24 -07:00
..
ia32/sys Resolve lingering atomic asm build issues. I think 2008-12-19 16:23:26 -08:00
rpc Remove nvpair_alloc_system.c change in libspl topic branch. 2010-05-18 12:47:08 -07:00
sys Remove libspl support for mlslabels 2010-07-22 16:37:29 -07:00
util Updates to linux-libspl 2010-06-14 15:47:54 -07:00
Makefile.am Remove libspl support for mlslabels 2010-07-22 16:37:29 -07:00
assert.h Revert "Remove declarations in VERIFY3_IMPL to save stack" 2010-08-06 11:08:24 -07:00
atomic.h First pass at getting userspace 64bit atomic ops working: 2008-12-19 15:11:43 -08:00
devid.h Update #ifndef/#defines 2008-12-17 10:10:32 -08:00
libdevinfo.h Update #ifndef/#defines 2008-12-17 10:10:32 -08:00
libshare.h Update #ifndef/#defines 2008-12-17 10:10:32 -08:00
limits.h Add missing limits 2008-12-22 15:17:57 -08:00
locale.h Add sys/time.h 2008-12-22 10:00:01 -08:00
priv.h Updates to linux-libspl 2010-06-14 15:47:54 -07:00
statcommon.h Updates to linux-libspl 2010-06-14 15:47:54 -07:00
stdio.h Add enable_extended_FILE_stdio #define 2008-12-22 10:34:22 -08:00
stdlib.h Cleanup some of the #ifndef/#defines 2008-12-17 10:06:55 -08:00
string.h Cleanup some of the #ifndef/#defines 2008-12-17 10:06:55 -08:00
strings.h Cleanup some of the #ifndef/#defines 2008-12-17 10:06:55 -08:00
synch.h Cleanup some of the #ifndef/#defines 2008-12-17 10:06:55 -08:00
thread.h Drop support for the Solaris user space thread_t API. This was just 2009-07-08 16:15:42 -07:00
tzfile.h Add missing tzfile.h 2008-12-22 15:04:47 -08:00
ucred.h Cleanup some of the #ifndef/#defines 2008-12-17 10:06:55 -08:00
umem.h Add umem_alloc_aligned() and honor cache_align field for umem caches 2010-03-10 11:51:43 -08:00
unistd.h Move zfs_config.h include to command line -include 2010-03-23 14:54:00 -07:00
zone.h Remove libspl support for mlslabels 2010-07-22 16:37:29 -07:00