Use the correct return type for getopt

Use the correct return type for getopt otherwise clang complains
about tautological-constant-out-of-range-compare.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Sterling Jensen <sterlingjensen@users.noreply.github.com>
Closes #11359
This commit is contained in:
sterlingjensen 2020-12-17 12:19:30 -06:00 committed by GitHub
parent be5c6d9653
commit fb188409f1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 5 additions and 5 deletions

View File

@ -8492,7 +8492,7 @@ zfs_do_wait(int argc, char **argv)
{ {
boolean_t enabled[ZFS_WAIT_NUM_ACTIVITIES]; boolean_t enabled[ZFS_WAIT_NUM_ACTIVITIES];
int error, i; int error, i;
char c; int c;
/* By default, wait for all types of activity. */ /* By default, wait for all types of activity. */
for (i = 0; i < ZFS_WAIT_NUM_ACTIVITIES; i++) for (i = 0; i < ZFS_WAIT_NUM_ACTIVITIES; i++)

View File

@ -44,7 +44,7 @@ int
main(int argc, char **argv) main(int argc, char **argv)
{ {
boolean_t verbose = B_FALSE; boolean_t verbose = B_FALSE;
char c; int c;
while ((c = getopt(argc, argv, "v")) != -1) { while ((c = getopt(argc, argv, "v")) != -1) {
switch (c) { switch (c) {
case 'v': case 'v':

View File

@ -10147,7 +10147,7 @@ int
zpool_do_wait(int argc, char **argv) zpool_do_wait(int argc, char **argv)
{ {
boolean_t verbose = B_FALSE; boolean_t verbose = B_FALSE;
char c; int c;
char *value; char *value;
int i; int i;
unsigned long count; unsigned long count;

View File

@ -421,7 +421,7 @@ int
zstream_do_redup(int argc, char *argv[]) zstream_do_redup(int argc, char *argv[])
{ {
boolean_t verbose = B_FALSE; boolean_t verbose = B_FALSE;
char c; int c;
while ((c = getopt(argc, argv, "v")) != -1) { while ((c = getopt(argc, argv, "v")) != -1) {
switch (c) { switch (c) {

View File

@ -457,7 +457,7 @@ main(int argc, char *argv[])
int failed_tests = 0; int failed_tests = 0;
struct timeval tp; struct timeval tp;
zfs_btree_t bt; zfs_btree_t bt;
char c; int c;
while ((c = getopt(argc, argv, "c:l:n:r:st:")) != -1) { while ((c = getopt(argc, argv, "c:l:n:r:st:")) != -1) {
switch (c) { switch (c) {