From f9e39f98a0f649c90b47dc547ed65072daec79f6 Mon Sep 17 00:00:00 2001 From: Paul Dagnelie Date: Fri, 19 Nov 2021 09:02:45 -0800 Subject: [PATCH] Add notes to system_taskq Reviewed-by: Matthew Ahrens Reviewed-by: George Melikov Reviewed-by: Tony Nguyen Signed-off-by: Paul Dagnelie Closes #12771 --- module/os/freebsd/spl/spl_taskq.c | 5 +++++ module/os/linux/spl/spl-taskq.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/module/os/freebsd/spl/spl_taskq.c b/module/os/freebsd/spl/spl_taskq.c index 3fa7939bdb..ba22c77b69 100644 --- a/module/os/freebsd/spl/spl_taskq.c +++ b/module/os/freebsd/spl/spl_taskq.c @@ -55,6 +55,11 @@ __FBSDID("$FreeBSD$"); static uint_t taskq_tsd; static uma_zone_t taskq_zone; +/* + * Global system-wide dynamic task queue available for all consumers. This + * taskq is not intended for long-running tasks; instead, a dedicated taskq + * should be created. + */ taskq_t *system_taskq = NULL; taskq_t *system_delay_taskq = NULL; taskq_t *dynamic_taskq = NULL; diff --git a/module/os/linux/spl/spl-taskq.c b/module/os/linux/spl/spl-taskq.c index fb25a41544..a879c28563 100644 --- a/module/os/linux/spl/spl-taskq.c +++ b/module/os/linux/spl/spl-taskq.c @@ -51,7 +51,11 @@ module_param(spl_taskq_thread_sequential, int, 0644); MODULE_PARM_DESC(spl_taskq_thread_sequential, "Create new taskq threads after N sequential tasks"); -/* Global system-wide dynamic task queue available for all consumers */ +/* + * Global system-wide dynamic task queue available for all consumers. This + * taskq is not intended for long-running tasks; instead, a dedicated taskq + * should be created. + */ taskq_t *system_taskq; EXPORT_SYMBOL(system_taskq); /* Global dynamic task queue for long delay */