Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix coverity defects: CID 147575, 147577, 147578, 147579 

CID 147575, Type:Unintentional integer overflow
CID 147577, Type:Unintentional integer overflow
CID 147578, Type:Unintentional integer overflow
CID 147579, Type:Unintentional integer overflow

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: cao.xuewen <cao.xuewen@zte.com.cn>
Closes #5365
This commit is contained in:
cao 2016-11-08 06:54:32 +08:00 committed by Brian Behlendorf
parent 3779913b35
commit f4bae2ed63
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libzfs/libzfs_sendrecv.c
View File

@ -259,7 +259,7 @@ cksummer(void *arg)
* a power of 2 if necessary. * a power of 2 if necessary.
*/ */
if (!ISP2(numbuckets)) if (!ISP2(numbuckets))
numbuckets = 1 << high_order_bit(numbuckets); numbuckets = 1ULL << high_order_bit(numbuckets);
ddt.dedup_hash_array = calloc(numbuckets, sizeof (dedup_entry_t *)); ddt.dedup_hash_array = calloc(numbuckets, sizeof (dedup_entry_t *));
ddt.ddecache = umem_cache_create("dde", sizeof (dedup_entry_t), 0, ddt.ddecache = umem_cache_create("dde", sizeof (dedup_entry_t), 0,

2
module/zfs/dmu_tx.c
View File

@ -755,7 +755,7 @@ dmu_tx_hold_zap(dmu_tx_t *tx, uint64_t object, int add, const char *name)
* block. So there will be at most 2 blocks total, * block. So there will be at most 2 blocks total,
* including the header block. * including the header block.
*/ */
dmu_tx_count_write(txh, 0, 2 << fzap_default_block_shift); dmu_tx_count_write(txh, 0, 2ULL << fzap_default_block_shift);
return; return;
} }

2
module/zfs/dnode_sync.c
View File

@ -292,7 +292,7 @@ free_children(dmu_buf_impl_t *db, uint64_t blkid, uint64_t nblks,
} }
/* If this whole block is free, free ourself too. */ /* If this whole block is free, free ourself too. */
for (i = 0, bp = db->db.db_data; i < 1 << epbs; i++, bp++) { for (i = 0, bp = db->db.db_data; i < 1ULL << epbs; i++, bp++) {
if (!BP_IS_HOLE(bp)) if (!BP_IS_HOLE(bp))
break; break;
} }

2
module/zfs/metaslab.c
View File

@ -1769,7 +1769,7 @@ metaslab_should_condense(metaslab_t *msp)
range_seg_t *rs; range_seg_t *rs;
uint64_t size, entries, segsz, object_size, optimal_size, record_size; uint64_t size, entries, segsz, object_size, optimal_size, record_size;
dmu_object_info_t doi; dmu_object_info_t doi;
uint64_t vdev_blocksize = 1 << msp->ms_group->mg_vd->vdev_ashift; uint64_t vdev_blocksize = 1ULL << msp->ms_group->mg_vd->vdev_ashift;
ASSERT(MUTEX_HELD(&msp->ms_lock)); ASSERT(MUTEX_HELD(&msp->ms_lock));
ASSERT(msp->ms_loaded); ASSERT(msp->ms_loaded);