From ed715283de8e65a30d777e9576399ab75014b6fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=BD=D0=B0=D0=B1?= Date: Tue, 5 Apr 2022 22:50:55 +0200 Subject: [PATCH] cmd: zed: rc: drop "should be owned by root and 0600" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It doesn't matter, 0600 are Weird Permissions, and it's even weirder to spec them for no reason ‒ it's perfectly fine if it's the usual 0:0 644, or literally anything else, so long as unprivileged users can't edit it (which (a) 644 accomplishes and (b) is at the administrator's discretion, it's not unheard of to have adm users and having it be 664 in that case is just as good; it's not our place to say) Reviewed-by: Brian Behlendorf Signed-off-by: Ahelenia Ziemiańska Closes #12544 Closes #13276 --- cmd/zed/zed.d/Makefile.am | 1 - cmd/zed/zed.d/zed.rc | 4 +--- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/cmd/zed/zed.d/Makefile.am b/cmd/zed/zed.d/Makefile.am index 3c0f5c3dd1..3efcfb3629 100644 --- a/cmd/zed/zed.d/Makefile.am +++ b/cmd/zed/zed.d/Makefile.am @@ -54,7 +54,6 @@ install-data-hook: -L "$(DESTDIR)$(zedconfdir)/$${f}" || \ ln -s "$(zedexecdir)/$${f}" "$(DESTDIR)$(zedconfdir)"; \ done - chmod 0600 "$(DESTDIR)$(zedconfdir)/zed.rc" # False positive: 1>&"${ZED_FLOCK_FD}" looks suspiciously similar to a >&filename bash extension CHECKBASHISMS_IGNORE = -e 'should be >word 2>&1' -e '&"$${ZED_FLOCK_FD}"' diff --git a/cmd/zed/zed.d/zed.rc b/cmd/zed/zed.d/zed.rc index a8fdc86c34..3c58a2c281 100644 --- a/cmd/zed/zed.d/zed.rc +++ b/cmd/zed/zed.d/zed.rc @@ -1,7 +1,5 @@ ## -# zed.rc -# -# This file should be owned by root and permissioned 0600. +# zed.rc – ZEDLET configuration. ## # shellcheck disable=SC2034