Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

get_key_material_https: removed bogus free() call 

The get_key_material_https() function error code path had a bogus
free() call, either resulting in double-free or free() of undefined
pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Co-authored-by: Harry Sintonen <sintonen@iki.fi>
Signed-off-by: Harry Sintonen <sintonen@iki.fi>
Closes #13198
This commit is contained in:
Harry Sintonen 2022-03-13 22:15:40 +02:00 committed by GitHub
parent 76bcffb7dc
commit ebcf12f763
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lib/libzfs/libzfs_crypto.c
View File

@ -614,7 +614,6 @@ get_key_material_https(libzfs_handle_t *hdl, const char *uri,
kfdok: kfdok:
if ((key = fdopen(kfd, "r+")) == NULL) { if ((key = fdopen(kfd, "r+")) == NULL) {
ret = errno; ret = errno;
free(path);
(void) close(kfd); (void) close(kfd);
zfs_error_aux(hdl, dgettext(TEXT_DOMAIN, zfs_error_aux(hdl, dgettext(TEXT_DOMAIN,
"Couldn't reopen temporary file: %s"), strerror(ret)); "Couldn't reopen temporary file: %s"), strerror(ret));