From ebbbe01e31f6cdc79b32a8de2f50691972d184f7 Mon Sep 17 00:00:00 2001 From: Rich Ercolani <214141+rincebrain@users.noreply.github.com> Date: Thu, 31 Mar 2022 13:09:18 -0400 Subject: [PATCH] Ask libtool to stop hiding some errors For #13083, curiously, it did not print the actual error, just that the compile failed with "Error 1". In theory, this flag should cause it to report errors twice sometimes. In practice, I'm pretty okay with reporting some twice if it avoids reporting some never. Reviewed-by: Brian Behlendorf Reviewed-by: Damian Szuberski Signed-off-by: Rich Ercolani Closes #13086 --- lib/libavl/Makefile.am | 3 +++ lib/libefi/Makefile.am | 3 +++ lib/libicp/Makefile.am | 2 ++ lib/libnvpair/Makefile.am | 3 +++ lib/libshare/Makefile.am | 3 +++ lib/libspl/Makefile.am | 3 +++ lib/libtpool/Makefile.am | 3 +++ lib/libunicode/Makefile.am | 3 +++ lib/libuutil/Makefile.am | 3 +++ lib/libzfs/Makefile.am | 3 +++ lib/libzfs_core/Makefile.am | 3 +++ lib/libzfsbootenv/Makefile.am | 3 +++ lib/libzpool/Makefile.am | 3 +++ lib/libzstd/Makefile.am | 2 ++ lib/libzutil/Makefile.am | 3 +++ 15 files changed, 43 insertions(+) diff --git a/lib/libavl/Makefile.am b/lib/libavl/Makefile.am index 2e0a431c77..de8ba34d5b 100644 --- a/lib/libavl/Makefile.am +++ b/lib/libavl/Makefile.am @@ -5,6 +5,9 @@ VPATH = $(top_srcdir)/module/avl/ # Includes kernel code, generate warnings for large stack frames AM_CFLAGS += $(FRAME_LARGER_THAN) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + noinst_LTLIBRARIES = libavl.la KERNEL_C = \ diff --git a/lib/libefi/Makefile.am b/lib/libefi/Makefile.am index b26f7a6dcd..5f77ac480a 100644 --- a/lib/libefi/Makefile.am +++ b/lib/libefi/Makefile.am @@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am AM_CFLAGS += $(LIBUUID_CFLAGS) $(ZLIB_CFLAGS) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + noinst_LTLIBRARIES = libefi.la USER_C = \ diff --git a/lib/libicp/Makefile.am b/lib/libicp/Makefile.am index e4a9ee8621..9a2510d0d2 100644 --- a/lib/libicp/Makefile.am +++ b/lib/libicp/Makefile.am @@ -6,6 +6,8 @@ VPATH = \ # Includes kernel code, generate warnings for large stack frames AM_CFLAGS += $(FRAME_LARGER_THAN) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress noinst_LTLIBRARIES = libicp.la diff --git a/lib/libnvpair/Makefile.am b/lib/libnvpair/Makefile.am index a3e1fa307f..f9f1eb5392 100644 --- a/lib/libnvpair/Makefile.am +++ b/lib/libnvpair/Makefile.am @@ -8,6 +8,9 @@ VPATH = \ # and required CFLAGS for libtirpc AM_CFLAGS += $(FRAME_LARGER_THAN) $(LIBTIRPC_CFLAGS) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + lib_LTLIBRARIES = libnvpair.la include $(top_srcdir)/config/Abigail.am diff --git a/lib/libshare/Makefile.am b/lib/libshare/Makefile.am index 7cef13c3da..0fce333506 100644 --- a/lib/libshare/Makefile.am +++ b/lib/libshare/Makefile.am @@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am DEFAULT_INCLUDES += -I$(srcdir) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + noinst_LTLIBRARIES = libshare.la USER_C = \ diff --git a/lib/libspl/Makefile.am b/lib/libspl/Makefile.am index 61432225a7..b59919bfb9 100644 --- a/lib/libspl/Makefile.am +++ b/lib/libspl/Makefile.am @@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am SUBDIRS = include +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + noinst_LTLIBRARIES = libspl_assert.la libspl.la libspl_assert_la_SOURCES = \ diff --git a/lib/libtpool/Makefile.am b/lib/libtpool/Makefile.am index 3aff56f05f..ce9d03a679 100644 --- a/lib/libtpool/Makefile.am +++ b/lib/libtpool/Makefile.am @@ -3,6 +3,9 @@ include $(top_srcdir)/config/Rules.am # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61118 AM_CFLAGS += $(NO_CLOBBERED) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + noinst_LTLIBRARIES = libtpool.la USER_C = \ diff --git a/lib/libunicode/Makefile.am b/lib/libunicode/Makefile.am index b82975f68e..5b12b3e916 100644 --- a/lib/libunicode/Makefile.am +++ b/lib/libunicode/Makefile.am @@ -5,6 +5,9 @@ VPATH = $(top_srcdir)/module/unicode # Includes kernel code, generate warnings for large stack frames AM_CFLAGS += $(FRAME_LARGER_THAN) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + noinst_LTLIBRARIES = libunicode.la KERNEL_C = \ diff --git a/lib/libuutil/Makefile.am b/lib/libuutil/Makefile.am index 16d5023451..05b7ed0db8 100644 --- a/lib/libuutil/Makefile.am +++ b/lib/libuutil/Makefile.am @@ -1,5 +1,8 @@ include $(top_srcdir)/config/Rules.am +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + lib_LTLIBRARIES = libuutil.la include $(top_srcdir)/config/Abigail.am diff --git a/lib/libzfs/Makefile.am b/lib/libzfs/Makefile.am index 7acaee4183..77e12b9e8d 100644 --- a/lib/libzfs/Makefile.am +++ b/lib/libzfs/Makefile.am @@ -8,6 +8,9 @@ VPATH = \ # Suppress unused but set variable warnings often due to ASSERTs AM_CFLAGS += $(LIBCRYPTO_CFLAGS) $(ZLIB_CFLAGS) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + pkgconfig_DATA = libzfs.pc lib_LTLIBRARIES = libzfs.la diff --git a/lib/libzfs_core/Makefile.am b/lib/libzfs_core/Makefile.am index 67e554dc87..33a889a095 100644 --- a/lib/libzfs_core/Makefile.am +++ b/lib/libzfs_core/Makefile.am @@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am pkgconfig_DATA = libzfs_core.pc +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + lib_LTLIBRARIES = libzfs_core.la include $(top_srcdir)/config/Abigail.am diff --git a/lib/libzfsbootenv/Makefile.am b/lib/libzfsbootenv/Makefile.am index 984df0b8a3..8a6bb76acf 100644 --- a/lib/libzfsbootenv/Makefile.am +++ b/lib/libzfsbootenv/Makefile.am @@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am pkgconfig_DATA = libzfsbootenv.pc +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + lib_LTLIBRARIES = libzfsbootenv.la include $(top_srcdir)/config/Abigail.am diff --git a/lib/libzpool/Makefile.am b/lib/libzpool/Makefile.am index db7c376318..4ce3b4cd2f 100644 --- a/lib/libzpool/Makefile.am +++ b/lib/libzpool/Makefile.am @@ -24,6 +24,9 @@ AM_CFLAGS += $(ZLIB_CFLAGS) AM_CFLAGS += -DLIB_ZPOOL_BUILD +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + lib_LTLIBRARIES = libzpool.la USER_C = \ diff --git a/lib/libzstd/Makefile.am b/lib/libzstd/Makefile.am index c9ed7e2aaf..e3bc5c446e 100644 --- a/lib/libzstd/Makefile.am +++ b/lib/libzstd/Makefile.am @@ -5,6 +5,8 @@ VPATH = $(top_srcdir)/module/zstd # -fno-tree-vectorize is set for gcc in zstd/common/compiler.h # Set it for other compilers, too. AM_CFLAGS += -fno-tree-vectorize +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress noinst_LTLIBRARIES = libzstd.la diff --git a/lib/libzutil/Makefile.am b/lib/libzutil/Makefile.am index 6351e0ebf6..f55b7798f1 100644 --- a/lib/libzutil/Makefile.am +++ b/lib/libzutil/Makefile.am @@ -2,6 +2,9 @@ include $(top_srcdir)/config/Rules.am AM_CFLAGS += $(LIBBLKID_CFLAGS) $(LIBUDEV_CFLAGS) +# See https://debbugs.gnu.org/cgi/bugreport.cgi?bug=54020 +AM_CFLAGS += -no-suppress + DEFAULT_INCLUDES += -I$(srcdir) noinst_LTLIBRARIES = libzutil.la