Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Bring per_txg_dirty_frees_percent back to 30 

The current value causes significant artificial slowdown during mass
parallel file removal, which can be observed both on FreeBSD and Linux
when running real workloads.

Sample results from Linux doing make -j 96 clean after an allyesconfig
modules build:

before: 4.14s user 6.79s system 48% cpu 22.631 total
after:	4.17s user 6.44s system 153% cpu 6.927 total

FreeBSD results in the ticket.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by:	Mateusz Guzik <mjguzik@gmail.com>
Closes #13932
Closes #13938
This commit is contained in:
Mateusz Guzik 2022-09-28 02:38:03 +02:00 committed by GitHub
parent af65073a07
commit eb9bec0a5d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
man/man4/zfs.4
View File

@ -1677,7 +1677,7 @@ prefetched during a pool traversal, like
.Nm zfs Cm send .Nm zfs Cm send
or other data crawling operations. or other data crawling operations.
. .
.It Sy zfs_per_txg_dirty_frees_percent Ns = Ns Sy 5 Ns % Pq ulong .It Sy zfs_per_txg_dirty_frees_percent Ns = Ns Sy 30 Ns % Pq ulong
Control percentage of dirtied indirect blocks from frees allowed into one TXG. Control percentage of dirtied indirect blocks from frees allowed into one TXG.
After this threshold is crossed, additional frees will wait until the next TXG. After this threshold is crossed, additional frees will wait until the next TXG.
.Sy 0 No disables this throttle. .Sy 0 No disables this throttle.

2
module/zfs/dmu.c
View File

@ -70,7 +70,7 @@ static int zfs_nopwrite_enabled = 1;
* will wait until the next TXG. * will wait until the next TXG.
* A value of zero will disable this throttle. * A value of zero will disable this throttle.
*/ */
static unsigned long zfs_per_txg_dirty_frees_percent = 5; static unsigned long zfs_per_txg_dirty_frees_percent = 30;
/* /*
* Enable/disable forcing txg sync when dirty checking for holes with lseek(). * Enable/disable forcing txg sync when dirty checking for holes with lseek().