From e1fcd940e7a550e0631fb7e80c5df6d84c446d28 Mon Sep 17 00:00:00 2001 From: John Wren Kennedy Date: Thu, 14 May 2020 10:39:47 -0600 Subject: [PATCH] ZTS: zpool_split_indirect deletes zfstest log file The cleanup routine for this test attempts to remove some temporary files with `rm -f $VDEV_*`, but VDEV_ is undefined. As a result, all files in the current working directory (/var/tmp/test_results/current) get removed instead. This includes the complete log file of all tests. Reviewed-by: Brian Behlendorf Reviewed-by: George Melikov Reviewed-by: George Amanakis Reviewed-by: Ryan Moeller Signed-off-by: John Kennedy Closes #10324 --- .../functional/cli_root/zpool_split/zpool_split_indirect.ksh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/zfs-tests/tests/functional/cli_root/zpool_split/zpool_split_indirect.ksh b/tests/zfs-tests/tests/functional/cli_root/zpool_split/zpool_split_indirect.ksh index d6b0e7358e..13f0d08b7f 100755 --- a/tests/zfs-tests/tests/functional/cli_root/zpool_split/zpool_split_indirect.ksh +++ b/tests/zfs-tests/tests/functional/cli_root/zpool_split/zpool_split_indirect.ksh @@ -16,6 +16,7 @@ # # Copyright (c) 2020, George Amanakis. All rights reserved. +# Copyright (c) 2020 by Delphix. All rights reserved. # . $STF_SUITE/include/libtest.shlib @@ -42,7 +43,7 @@ function cleanup if poolexists $TESTPOOL2 ; then destroy_pool $TESTPOOL2 fi - rm -f $VDEV_* + rm -f $VDEV_TEMP $VDEV_M1 $VDEV_M2 } log_onexit cleanup