From de2ac3f700a3aabb4e2602e86328b1cbf778a356 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=89rico=20Nogueira=20Rolim?= <34201958+ericonr@users.noreply.github.com> Date: Thu, 10 Dec 2020 02:24:59 -0300 Subject: [PATCH] mount_zfs: print strerror instead of errno for error reporting MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Tracking down an error message with the errno value can be difficult, using strerror makes the error message clearer. Reviewed-by: Brian Behlendorf Signed-off-by: Érico Rolim Closes #11303 --- cmd/mount_zfs/mount_zfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/cmd/mount_zfs/mount_zfs.c b/cmd/mount_zfs/mount_zfs.c index 0e7810703e..ca39d22847 100644 --- a/cmd/mount_zfs/mount_zfs.c +++ b/cmd/mount_zfs/mount_zfs.c @@ -110,8 +110,8 @@ mtab_update(char *dataset, char *mntpoint, char *type, char *mntopts) if (!fp) { (void) fprintf(stderr, gettext( "filesystem '%s' was mounted, but /etc/mtab " - "could not be opened due to error %d\n"), - dataset, errno); + "could not be opened due to error: %s\n"), + dataset, strerror(errno)); return (MOUNT_FILEIO); } @@ -119,8 +119,8 @@ mtab_update(char *dataset, char *mntpoint, char *type, char *mntopts) if (error) { (void) fprintf(stderr, gettext( "filesystem '%s' was mounted, but /etc/mtab " - "could not be updated due to error %d\n"), - dataset, errno); + "could not be updated due to error: %s\n"), + dataset, strerror(errno)); return (MOUNT_FILEIO); } @@ -200,8 +200,8 @@ main(int argc, char **argv) /* canonicalize the mount point */ if (realpath(argv[1], mntpoint) == NULL) { (void) fprintf(stderr, gettext("filesystem '%s' cannot be " - "mounted at '%s' due to canonicalization error %d.\n"), - dataset, argv[1], errno); + "mounted at '%s' due to canonicalization error: %s\n"), + dataset, argv[1], strerror(errno)); return (MOUNT_SYSERR); }