From db6be852da8762059c40dd2ae6bfb9c19a25e0af Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Tue, 26 Mar 2019 13:57:40 -0700 Subject: [PATCH] ZTS: Detect e2fsprogs verity issue The projectid_001_pos and projecttree_001_pos test cases use the lsattr command to detect that the project quota bit is set correctly. Due to a bug in e2fsprogs-1.44.4 setting the Project 'P' bit also results in the Verity 'V' bit being reported as set. This will result in the test case failing. The issue has been resolved in e2fsprogs but in order to avoid testing failures these two test cases are skipped when e2fsprogs-1.44.4 is installed. https://github.com/tytso/e2fsprogs/commit/7e5a95e3d Reviewed-by: Richard Elling Reviewed-by: George Melikov Signed-off-by: Brian Behlendorf Closes #8534 --- .../functional/projectquota/projectid_001_pos.ksh | 10 ++++++++++ .../functional/projectquota/projecttree_001_pos.ksh | 10 ++++++++++ 2 files changed, 20 insertions(+) diff --git a/tests/zfs-tests/tests/functional/projectquota/projectid_001_pos.ksh b/tests/zfs-tests/tests/functional/projectquota/projectid_001_pos.ksh index 7cd6925797..44af9941b9 100755 --- a/tests/zfs-tests/tests/functional/projectquota/projectid_001_pos.ksh +++ b/tests/zfs-tests/tests/functional/projectquota/projectid_001_pos.ksh @@ -55,6 +55,16 @@ if ! lsattr -pd > /dev/null 2>&1; then log_unsupported "Current e2fsprogs does not support set/show project ID" fi +# +# e2fsprogs-1.44.4 incorrectly reports verity 'V' bit when the project 'P' +# bit is set. Skip this test when 1.44.4 is installed to prevent failures. +# +# https://github.com/tytso/e2fsprogs/commit/7e5a95e3d +# +if lsattr -V 2>&1 | grep "lsattr 1.44.4"; then + log_unsupported "Current e2fsprogs incorrectly reports 'V' verity bit" +fi + log_onexit cleanup log_assert "Check project ID/flags can be set/inherited properly" diff --git a/tests/zfs-tests/tests/functional/projectquota/projecttree_001_pos.ksh b/tests/zfs-tests/tests/functional/projectquota/projecttree_001_pos.ksh index 1e4ef309f1..0402e345df 100755 --- a/tests/zfs-tests/tests/functional/projectquota/projecttree_001_pos.ksh +++ b/tests/zfs-tests/tests/functional/projectquota/projecttree_001_pos.ksh @@ -56,6 +56,16 @@ if ! lsattr -pd > /dev/null 2>&1; then log_unsupported "Current e2fsprogs does not support set/show project ID" fi +# +# e2fsprogs-1.44.4 incorrectly reports verity 'V' bit when the project 'P' +# bit is set. Skip this test when 1.44.4 is installed to prevent failures. +# +# https://github.com/tytso/e2fsprogs/commit/7e5a95e3d +# +if lsattr -V 2>&1 | grep "lsattr 1.44.4"; then + log_unsupported "Current e2fsprogs incorrectly reports 'V' verity bit" +fi + log_onexit cleanup log_assert "Check 'zfs project' is compatible with chattr/lsattr"