From cd26b217dcc136d025b845e61692bb34cf37552b Mon Sep 17 00:00:00 2001 From: Rich Ercolani <214141+rincebrain@users.noreply.github.com> Date: Mon, 24 Jan 2022 18:54:52 -0500 Subject: [PATCH] Add explicit timeout to test step If we die from timeout of the whole GH action run, we don't run the collect step afterward, which can make it hard to investigate the timeout. If we timeout first in the test action, though, it qualifies as failure, and collects appropriately. (330 minutes seems like an acceptable tradeoff between the 6h timeout by default on the action and the 4h and change "functional" usually takes.) Reviewed-by: George Melikov Reviewed-by: Brian Behlendorf Signed-off-by: Rich Ercolani Closes #12999 --- .github/workflows/zfs-tests-functional.yml | 1 + .github/workflows/zfs-tests-sanity.yml | 1 + 2 files changed, 2 insertions(+) diff --git a/.github/workflows/zfs-tests-functional.yml b/.github/workflows/zfs-tests-functional.yml index 19d3f57bae..40d03d25d4 100644 --- a/.github/workflows/zfs-tests-functional.yml +++ b/.github/workflows/zfs-tests-functional.yml @@ -64,6 +64,7 @@ jobs: - name: Tests run: | /usr/share/zfs/zfs-tests.sh -vR -s 3G + timeout-minutes: 330 - name: Prepare artifacts if: failure() run: | diff --git a/.github/workflows/zfs-tests-sanity.yml b/.github/workflows/zfs-tests-sanity.yml index 2b97fd6182..d1dc0e88c1 100644 --- a/.github/workflows/zfs-tests-sanity.yml +++ b/.github/workflows/zfs-tests-sanity.yml @@ -60,6 +60,7 @@ jobs: - name: Tests run: | /usr/share/zfs/zfs-tests.sh -vR -s 3G -r sanity + timeout-minutes: 330 - name: Prepare artifacts if: failure() run: |