From c45254b0ecccd7e9b26b84fe605cdb87901f3ba9 Mon Sep 17 00:00:00 2001 From: Giuseppe Di Natale Date: Mon, 23 Oct 2017 14:01:43 -0700 Subject: [PATCH] Correct flake8 errors after STYLE builder update Fix new flake8 errors related to bare excepts and ambiguous variable names due to a STYLE builder update. Reviewed-by: George Melikov Reviewed-by: Brian Behlendorf Signed-off-by: Giuseppe Di Natale Closes #6776 --- cmd/arcstat/arcstat.py | 2 +- tests/test-runner/cmd/test-runner.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cmd/arcstat/arcstat.py b/cmd/arcstat/arcstat.py index b743fd8bc4..d969da8d4e 100755 --- a/cmd/arcstat/arcstat.py +++ b/cmd/arcstat/arcstat.py @@ -238,7 +238,7 @@ def get_terminal_lines(): data = fcntl.ioctl(sys.stdout.fileno(), termios.TIOCGWINSZ, '1234') sz = struct.unpack('hh', data) return sz[0] - except: + except Exception: pass diff --git a/tests/test-runner/cmd/test-runner.py b/tests/test-runner/cmd/test-runner.py index 4c53257dfb..8ad903c24f 100755 --- a/tests/test-runner/cmd/test-runner.py +++ b/tests/test-runner/cmd/test-runner.py @@ -150,7 +150,7 @@ class Cmd(object): try: kp = Popen(cmd) kp.wait() - except: + except Exception: pass def update_cmd_privs(self, cmd, user): @@ -629,16 +629,16 @@ class TestRun(object): base = self.outputdir while not done: - l = [] + paths = [] components -= 1 for testfile in tmp_dict.keys(): uniq = '/'.join(testfile.split('/')[components:]).lstrip('/') - if uniq not in l: - l.append(uniq) + if uniq not in paths: + paths.append(uniq) tmp_dict[testfile].outputdir = os.path.join(base, uniq) else: break - done = total == len(l) + done = total == len(paths) def setup_logging(self, options): """