Avoid memory copy when verifying raidz/draid parity
Before this change for every valid parity column raidz_parity_verify() allocated new buffer and copied there existing data, then recalculated the parity and compared the result with the copy. This patch removes the memory copy, simply swapping original buffer pointers with newly allocated empty ones for parity recalculation and comparison. Original buffers with potentially incorrect parity data are then just freed, while new recalculated ones are used for repair. On a pool of 12 4-wide raidz vdevs, storing 1.5TB of 16MB blocks, this change reduces memory traffic during scrub by 17% and total unhalted CPU time by 25%. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Alexander Motin <mav@FreeBSD.org> Sponsored-By: iXsystems, Inc. Closes #13613
This commit is contained in:
parent
03e33b2bb8
commit
bbb50e6129
module/zfs
|
@ -1721,8 +1721,9 @@ raidz_parity_verify(zio_t *zio, raidz_row_t *rr)
|
|||
if (!rc->rc_tried || rc->rc_error != 0)
|
||||
continue;
|
||||
|
||||
orig[c] = abd_alloc_sametype(rc->rc_abd, rc->rc_size);
|
||||
abd_copy(orig[c], rc->rc_abd, rc->rc_size);
|
||||
orig[c] = rc->rc_abd;
|
||||
ASSERT3U(abd_get_size(rc->rc_abd), ==, rc->rc_size);
|
||||
rc->rc_abd = abd_alloc_linear(rc->rc_size, B_FALSE);
|
||||
}
|
||||
|
||||
/*
|
||||
|
|
Loading…
Reference in New Issue