Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

`checkabi`/`storeabi` relevant only to x86_64 

The stored ABI files are for the x86_64 architecture.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes #11345
Closes #13104
This commit is contained in:
Damian Szuberski 2022-02-16 20:48:01 +01:00 committed by GitHub
parent 0df22afea2
commit ba6005175e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 24 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Makefile.am
View File

@ -138,20 +138,10 @@ SHELLCHECKSCRIPTS = autogen.sh
PHONY += checkabi storeabi PHONY += checkabi storeabi
checklibabiversion: checkabi: lib
libabiversion=`abidw -v | $(SED) 's/[^0-9]//g'`; \
if test $$libabiversion -lt "200"; then \
/bin/echo -e "\n" \
"*** Please use libabigail 2.0.0 version or newer;\n" \
"*** otherwise results are not consistent!\n" \
"(or see https://github.com/openzfs/libabigail-docker )\n"; \
exit 1; \
fi;
checkabi: checklibabiversion lib
$(MAKE) -C lib checkabi $(MAKE) -C lib checkabi
storeabi: checklibabiversion lib storeabi: lib
$(MAKE) -C lib storeabi $(MAKE) -C lib storeabi
PHONY += mancheck PHONY += mancheck

25
config/Abigail.am
View File

@ -12,9 +12,24 @@
# a mechanism for suppressing harmless warnings. # a mechanism for suppressing harmless warnings.
# #
PHONY += checkabi storeabi PHONY += checkabi storeabi check_libabi_version allow_libabi_only_for_x86_64
checkabi: check_libabi_version:
libabiversion=`abidw -v | $(SED) 's/[^0-9]//g'`; \
if test $$libabiversion -lt "200"; then \
/bin/echo -e "\n" \
"*** Please use libabigail 2.0.0 version or newer;\n" \
"*** otherwise results are not consistent!\n" \
"(or see https://github.com/openzfs/libabigail-docker )\n"; \
exit 1; \
fi;
allow_libabi_only_for_x86_64:
echo '*** ABI definitions provided apply only to x86_64 architecture'
echo '*** Skipping `checkabi`/`storeabi` target and assuming success.'
if TARGET_CPU_X86_64
checkabi: check_libabi_version
for lib in $(lib_LTLIBRARIES) ; do \ for lib in $(lib_LTLIBRARIES) ; do \
abidiff --no-unreferenced-symbols \ abidiff --no-unreferenced-symbols \
--headers-dir1 ../../include \ --headers-dir1 ../../include \
@ -22,7 +37,7 @@ checkabi:
$${lib%.la}.abi .libs/$${lib%.la}.so ; \ $${lib%.la}.abi .libs/$${lib%.la}.so ; \
done done
storeabi: storeabi: check_libabi_version
cd .libs ; \ cd .libs ; \
for lib in $(lib_LTLIBRARIES) ; do \ for lib in $(lib_LTLIBRARIES) ; do \
abidw --no-show-locs \ abidw --no-show-locs \
@ -31,3 +46,7 @@ storeabi:
--type-id-style hash \ --type-id-style hash \
$${lib%.la}.so > ../$${lib%.la}.abi ; \ $${lib%.la}.so > ../$${lib%.la}.abi ; \
done done
else
checkabi: allow_libabi_only_for_x86_64
storeabi: allow_libabi_only_for_x86_64
endif