From b1f61f05b4b2edc77ec5f3d28d041d7b3c873f01 Mon Sep 17 00:00:00 2001 From: Olaf Faaland Date: Thu, 22 Feb 2018 09:14:46 -0800 Subject: [PATCH] Do not initiate MMP writes while pool is suspended While the pool is suspended on host A, it may be imported on host B. If host A continued to write MMP blocks, it would be blindly overwriting MMP blocks written by host B, and the blocks written by host A would have outdated txg information. Reviewed-by: Giuseppe Di Natale Reviewed-by: Brian Behlendorf Signed-off-by: Olaf Faaland Closes #7182 --- module/zfs/mmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/zfs/mmp.c b/module/zfs/mmp.c index 1dfb7c05b4..d003d79deb 100644 --- a/module/zfs/mmp.c +++ b/module/zfs/mmp.c @@ -437,7 +437,7 @@ mmp_thread(spa_t *spa) zio_suspend(spa, NULL); } - if (multihost) + if (multihost && !suspended) mmp_write_uberblock(spa); CALLB_CPR_SAFE_BEGIN(&cpr);