Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Linux: zfs_zaccess_trivial() should always call generic_permission() 

Building with Clang on Linux generates a warning that err could be
uninitialized if mnt_ns is a NULL pointer. However, mnt_ns should never
be NULL, so there is no need to put this behind an if statement.  Taking
it outside of the if statement means that the possibility of err being
uninitialized goes from being always zero in a way that the compiler
could not realize to a way that is always zero in a way that the
compiler can realize.

Sponsored-By: Wasabi Technology, Inc.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Youzhong Yang <yyang@mathworks.com>
Signed-off-by: Richard Yao <richard.yao@klarasystems.com>
Closes #14738
This commit is contained in:
Richard Yao 2023-04-11 17:50:43 +00:00 committed by Brian Behlendorf
parent a10c645616
commit ab71b24d20
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
module/os/linux/zfs/zfs_acl.c
View File

@ -2466,8 +2466,7 @@ zfs_zaccess_trivial(znode_t *zp, uint32_t *working_mode, cred_t *cr,
#if (defined(HAVE_IOPS_PERMISSION_USERNS) || \ #if (defined(HAVE_IOPS_PERMISSION_USERNS) || \
defined(HAVE_IOPS_PERMISSION_IDMAP)) defined(HAVE_IOPS_PERMISSION_IDMAP))
if (mnt_ns) err = generic_permission(mnt_ns, ZTOI(zp), mask);
err = generic_permission(mnt_ns, ZTOI(zp), mask);
#else #else
err = generic_permission(ZTOI(zp), mask); err = generic_permission(ZTOI(zp), mask);
#endif #endif