From aa7aab6c457f106d2b794b9adf3fe5aa451ad8e9 Mon Sep 17 00:00:00 2001 From: Tomohiro Kusumi Date: Thu, 4 Jul 2019 05:03:22 +0900 Subject: [PATCH] Fail early on bio corruption confirmed on 5.2-rc1 Unable to import zpool with "Large kmem_alloc" warning due to corrupted bio's with invalid # of page vectors. See #8867 for details. Fail early with ENOMEM. Reviewed-by: Brian Behlendorf Reviewed-by: Tony Hutter Signed-off-by: Tomohiro Kusumi Closes #8867 Closes #8961 --- module/zfs/vdev_disk.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/module/zfs/vdev_disk.c b/module/zfs/vdev_disk.c index 1686ddfce7..8f06c41175 100644 --- a/module/zfs/vdev_disk.c +++ b/module/zfs/vdev_disk.c @@ -621,6 +621,7 @@ retry: bio_offset = io_offset; bio_size = io_size; for (i = 0; i <= dr->dr_bio_count; i++) { + unsigned int nr_iovecs; /* Finished constructing bio's for given buffer */ if (bio_size <= 0) @@ -638,10 +639,11 @@ retry: } /* bio_alloc() with __GFP_WAIT never returns NULL */ - dr->dr_bio[i] = bio_alloc(GFP_NOIO, - MIN(abd_nr_pages_off(zio->io_abd, bio_size, abd_offset), - BIO_MAX_PAGES)); - if (unlikely(dr->dr_bio[i] == NULL)) { + nr_iovecs = MIN(abd_nr_pages_off(zio->io_abd, bio_size, + abd_offset), BIO_MAX_PAGES); + dr->dr_bio[i] = bio_alloc(GFP_NOIO, nr_iovecs); + if (unlikely(dr->dr_bio[i] == NULL || + (unsigned int)dr->dr_bio[i]->bi_max_vecs != nr_iovecs)) { vdev_disk_dio_free(dr); return (SET_ERROR(ENOMEM)); }