Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Change location of current symlink created by test-runner 

test-runner should be creating the current symlink in the
directory above the output directory. In a previous commit,
the current symlink was placed in the current working
directory, which could be inaccessible. It is more likely
that the output directory is always accessible.

This is needed because without this there's no deterministic
way to get the path to ZFS Test Suite results until after the
test suite has started. This makes it difficult for buildbot to
follow the log file.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Closes #5314
This commit is contained in:
Giuseppe Di Natale 2016-10-24 10:24:10 -07:00 committed by Brian Behlendorf
parent 24cdeaf12e
commit a85cefa35c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/test-runner/cmd/test-runner.py
View File

@ -685,11 +685,12 @@ class TestRun(object):
""" """
Walk through all the Tests and TestGroups, calling run(). Walk through all the Tests and TestGroups, calling run().
""" """
logsymlink = os.path.join(os.getcwd(), 'current')
try: try:
os.chdir(self.outputdir) os.chdir(self.outputdir)
except OSError: except OSError:
fail('Could not change to directory %s' % self.outputdir) fail('Could not change to directory %s' % self.outputdir)
# make a symlink to the output for the currently running test
logsymlink = os.path.join(self.outputdir, '../current')
if os.path.islink(logsymlink): if os.path.islink(logsymlink):
os.unlink(logsymlink) os.unlink(logsymlink)
if not os.path.exists(logsymlink): if not os.path.exists(logsymlink):