Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

zio: try to execute TYPE_NULL ZIOs on the current task 

Many TYPE_NULL ZIOs are used to provide a sync point for child ZIOs, and
do not do any actual work themselves. However, they are still dispatched
to a dedicated, single-thread taskq, which leads to their execution
being entirely task switch and dequeue overhead for no actual reason.

This commit changes it so that when selecting a parent ZIO to execute,
if the parent is TYPE_NULL and has no done function (that is, no
additional work), it is executed on the same thread. This reduces task
switches and frees up CPU cores for other work.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Closes #16134
This commit is contained in:
Rob N 2024-04-30 08:57:32 +10:00 committed by GitHub
parent c3f2f1aa2d
commit a6edc0adb2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
module/zfs/zio.c
View File

@ -803,9 +803,10 @@ zio_notify_parent(zio_t *pio, zio_t *zio, enum zio_wait_type wait,
/* /*
* If we can tell the caller to execute this parent next, do * If we can tell the caller to execute this parent next, do
* so. We only do this if the parent's zio type matches the * so. We do this if the parent's zio type matches the child's
* child's type. Otherwise dispatch the parent zio in its * type, or if it's a zio_null() with no done callback, and so
* own taskq. * has no actual work to do. Otherwise dispatch the parent zio
* in its own taskq.
* *
* Having the caller execute the parent when possible reduces * Having the caller execute the parent when possible reduces
* locking on the zio taskq's, reduces context switch * locking on the zio taskq's, reduces context switch
@ -825,7 +826,8 @@ zio_notify_parent(zio_t *pio, zio_t *zio, enum zio_wait_type wait,
* of writes for spa_sync(), and the chain of ZIL blocks. * of writes for spa_sync(), and the chain of ZIL blocks.
*/ */
if (next_to_executep != NULL && *next_to_executep == NULL && if (next_to_executep != NULL && *next_to_executep == NULL &&
pio->io_type == zio->io_type) { (pio->io_type == zio->io_type ||
(pio->io_type == ZIO_TYPE_NULL && !pio->io_done))) {
*next_to_executep = pio; *next_to_executep = pio;
} else { } else {
zio_taskq_dispatch(pio, type, B_FALSE); zio_taskq_dispatch(pio, type, B_FALSE);