Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

zpool: misc. cleanup 

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12968
This commit is contained in:
наб 2022-01-12 17:37:08 +01:00 committed by Brian Behlendorf
parent 0481eabfa1
commit a401a2c54a
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
cmd/zpool/zpool_main.c
View File

@ -3218,11 +3218,9 @@ do_import(nvlist_t *config, const char *newname, const char *mntopts,
* Loading keys is best effort. We don't want to return immediately * Loading keys is best effort. We don't want to return immediately
* if it fails but we do want to give the error to the caller. * if it fails but we do want to give the error to the caller.
*/ */
if (flags & ZFS_IMPORT_LOAD_KEYS) { if (flags & ZFS_IMPORT_LOAD_KEYS &&
ret = zfs_crypto_attempt_load_keys(g_zfs, name); zfs_crypto_attempt_load_keys(g_zfs, name) != 0)
if (ret != 0)
ret = 1; ret = 1;
}
if (zpool_get_state(zhp) != POOL_STATE_UNAVAIL && if (zpool_get_state(zhp) != POOL_STATE_UNAVAIL &&
!(flags & ZFS_IMPORT_ONLY) && !(flags & ZFS_IMPORT_ONLY) &&
@ -3272,7 +3270,7 @@ import_pools(nvlist_t *pools, nvlist_t *props, char *mntopts, int flags,
if (first) if (first)
first = B_FALSE; first = B_FALSE;
else if (!do_all) else if (!do_all)
(void) printf("\n"); (void) putchar('\n');
if (do_all) { if (do_all) {
err |= do_import(config, NULL, mntopts, err |= do_import(config, NULL, mntopts,
@ -3723,9 +3721,8 @@ zpool_do_import(int argc, char **argv)
if (argc == 0 && geteuid() != 0) { if (argc == 0 && geteuid() != 0) {
(void) fprintf(stderr, gettext("cannot " (void) fprintf(stderr, gettext("cannot "
"discover pools: permission denied\n")); "discover pools: permission denied\n"));
if (searchdirs != NULL)
free(searchdirs);
free(searchdirs);
nvlist_free(props); nvlist_free(props);
nvlist_free(policy); nvlist_free(policy);
return (1); return (1);