Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

fix: variable type with zfs-tests/cmd/clonefile.c 

Compiling on arm64 freebsd-13.2 and arm64 almalinux-8 brings currently
this error:

```
  CC       tests/zfs-tests/cmd/clonefile.o
tests/zfs-tests/cmd/clonefile.c:166:43: error: result of comparison of \
constant -1 with expression of type 'char' is always true \
[-Werror,-Wtautological-constant-out-of-range-compare]
        while ((c = getopt(argc, argv, "crfdq")) != -1) {
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~
1 error generated.
gmake[2]: *** [Makefile:8675: tests/zfs-tests/cmd/clonefile.o] Error 1
```

Fix: use correct variable type `int`.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Rob Norris <robn@despairlabs.com>
Signed-off-by: Tino Reichardt <milky-zfs@mcmilk.de>
Closes #15783
This commit is contained in:
Tino Reichardt 2024-01-17 18:06:14 +01:00 committed by GitHub
parent e3d3d772de
commit a0b2a93c41
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/zfs-tests/cmd/clonefile.c
View File

@ -162,7 +162,7 @@ main(int argc, char **argv)
{ {
cf_mode_t mode = CF_MODE_NONE; cf_mode_t mode = CF_MODE_NONE;
char c; int c;
while ((c = getopt(argc, argv, "crfdq")) != -1) { while ((c = getopt(argc, argv, "crfdq")) != -1) {
switch (c) { switch (c) {
case 'c': case 'c':