Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix wrong assertion in libzfs diff error handling 

In compare(), all error cases set the error code to EPIPE, so when an
error is set, the correct assertion to make is that the error is EPIPE,
not EINVAL.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@freqlabs.com>
Closes #8743
This commit is contained in:
Ryan Moeller 2019-05-19 17:31:54 -07:00 committed by Brian Behlendorf
parent e61b53475e
commit 9dc41a769d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libzfs/libzfs_diff.c
View File

@ -478,7 +478,7 @@ differ(void *arg)
if (err) if (err)
return ((void *)-1); return ((void *)-1);
if (di->zerr) { if (di->zerr) {
ASSERT(di->zerr == EINVAL); ASSERT(di->zerr == EPIPE);
(void) snprintf(di->errbuf, sizeof (di->errbuf), (void) snprintf(di->errbuf, sizeof (di->errbuf),
dgettext(TEXT_DOMAIN, dgettext(TEXT_DOMAIN,
"Internal error: bad data from diff IOCTL")); "Internal error: bad data from diff IOCTL"));