From 9c470dc6c0a44c2ac78e6bf4d75445087395f8ad Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Thu, 15 Apr 2021 08:53:08 -0700 Subject: [PATCH] Fix 'make checkbashisms` warnings The awk command used by the checkbashisms target incorrectly adds the escape character before the ! and # characters. This results in the following warnings because these characters do not need to be escaped. awk: cmd. line:1: warning: regexp escape sequence `\!' is not a known regexp operator awk: cmd. line:1: warning: regexp escape sequence `\#' is not a known regexp operator Remove the unneeded escape character before ! and #. Valid escape sequences are: https://www.gnu.org/software/gawk/manual/html_node/Escape-Sequences.html Reviewed-by: George Melikov Reviewed-by: Ryan Moeller Signed-off-by: Brian Behlendorf Closes #11902 --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index dd48b4a2c9..30c61dda27 100644 --- a/Makefile.am +++ b/Makefile.am @@ -161,7 +161,7 @@ checkbashisms: -o -name '90zfs' -prune \ -o -type f ! -name 'config*' \ ! -name 'libtool' \ - -exec sh -c 'awk "NR==1 && /\#\!.*bin\/sh.*/ {print FILENAME;}" "{}"' \;); \ + -exec sh -c 'awk "NR==1 && /#!.*bin\/sh.*/ {print FILENAME;}" "{}"' \;); \ else \ echo "skipping checkbashisms because checkbashisms is not installed"; \ fi