Make more taskq parameters writable

There is no reason for these module parameters to be read-only.
Being modified they just apply on next pool import/creation, that
is useful for testing different values.

Reviewed-by: Rich Ercolani <rincebrain@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Closes #16118
This commit is contained in:
Alexander Motin 2024-04-24 17:38:48 -04:00 committed by Brian Behlendorf
parent 0f1e8ba2f8
commit 938d1588eb
2 changed files with 10 additions and 6 deletions

View File

@ -2324,8 +2324,8 @@ Prioritize requeued I/O.
. .
.It Sy zio_taskq_batch_pct Ns = Ns Sy 80 Ns % Pq uint .It Sy zio_taskq_batch_pct Ns = Ns Sy 80 Ns % Pq uint
Percentage of online CPUs which will run a worker thread for I/O. Percentage of online CPUs which will run a worker thread for I/O.
These workers are responsible for I/O work such as compression and These workers are responsible for I/O work such as compression, encryption,
checksum calculations. checksum and parity calculations.
Fractional number of CPUs will be rounded down. Fractional number of CPUs will be rounded down.
.Pp .Pp
The default value of The default value of
@ -2333,6 +2333,7 @@ The default value of
was chosen to avoid using all CPUs which can result in was chosen to avoid using all CPUs which can result in
latency issues and inconsistent application performance, latency issues and inconsistent application performance,
especially when slower compression and/or checksumming is enabled. especially when slower compression and/or checksumming is enabled.
Set value only applies to pools imported/created after that.
. .
.It Sy zio_taskq_batch_tpq Ns = Ns Sy 0 Pq uint .It Sy zio_taskq_batch_tpq Ns = Ns Sy 0 Pq uint
Number of worker threads per taskq. Number of worker threads per taskq.
@ -2342,16 +2343,19 @@ while higher reduces lock contention.
If If
.Sy 0 , .Sy 0 ,
generate a system-dependent value close to 6 threads per taskq. generate a system-dependent value close to 6 threads per taskq.
Set value only applies to pools imported/created after that.
. .
.It Sy zio_taskq_read Ns = Ns Sy fixed,1,8 null scale null Pq charp .It Sy zio_taskq_read Ns = Ns Sy fixed,1,8 null scale null Pq charp
Set the queue and thread configuration for the IO read queues. Set the queue and thread configuration for the IO read queues.
This is an advanced debugging parameter. This is an advanced debugging parameter.
Don't change this unless you understand what it does. Don't change this unless you understand what it does.
Set values only apply to pools imported/created after that.
. .
.It Sy zio_taskq_write Ns = Ns Sy batch fixed,1,5 scale fixed,1,5 Pq charp .It Sy zio_taskq_write Ns = Ns Sy batch fixed,1,5 scale fixed,1,5 Pq charp
Set the queue and thread configuration for the IO write queues. Set the queue and thread configuration for the IO write queues.
This is an advanced debugging parameter. This is an advanced debugging parameter.
Don't change this unless you understand what it does. Don't change this unless you understand what it does.
Set values only apply to pools imported/created after that.
. .
.It Sy zvol_inhibit_dev Ns = Ns Sy 0 Ns | Ns 1 Pq uint .It Sy zvol_inhibit_dev Ns = Ns Sy 0 Ns | Ns 1 Pq uint
Do not create zvol device nodes. Do not create zvol device nodes.

View File

@ -10561,10 +10561,10 @@ ZFS_MODULE_PARAM(zfs_spa, spa_, load_verify_data, INT, ZMOD_RW,
ZFS_MODULE_PARAM(zfs_spa, spa_, load_print_vdev_tree, INT, ZMOD_RW, ZFS_MODULE_PARAM(zfs_spa, spa_, load_print_vdev_tree, INT, ZMOD_RW,
"Print vdev tree to zfs_dbgmsg during pool import"); "Print vdev tree to zfs_dbgmsg during pool import");
ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_pct, UINT, ZMOD_RD, ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_pct, UINT, ZMOD_RW,
"Percentage of CPUs to run an IO worker thread"); "Percentage of CPUs to run an IO worker thread");
ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_tpq, UINT, ZMOD_RD, ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_tpq, UINT, ZMOD_RW,
"Number of threads per IO worker taskqueue"); "Number of threads per IO worker taskqueue");
/* BEGIN CSTYLED */ /* BEGIN CSTYLED */
@ -10595,10 +10595,10 @@ ZFS_MODULE_PARAM(zfs_livelist_condense, zfs_livelist_condense_, new_alloc, INT,
#ifdef _KERNEL #ifdef _KERNEL
ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_read, ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_read,
spa_taskq_read_param_set, spa_taskq_read_param_get, ZMOD_RD, spa_taskq_read_param_set, spa_taskq_read_param_get, ZMOD_RW,
"Configure IO queues for read IO"); "Configure IO queues for read IO");
ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_write, ZFS_MODULE_VIRTUAL_PARAM_CALL(zfs_zio, zio_, taskq_write,
spa_taskq_write_param_set, spa_taskq_write_param_get, ZMOD_RD, spa_taskq_write_param_set, spa_taskq_write_param_get, ZMOD_RW,
"Configure IO queues for write IO"); "Configure IO queues for write IO");
#endif #endif
/* END CSTYLED */ /* END CSTYLED */