Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Proposed fix for oops on SIGINT in splat atomic:64-bit test. 

The threads in the splat atomic:64-bit test share the data structure
atomic_priv_t ap, which lives on the kernel stack of the splat user-space
utility.  If splat terminates before the threads, accesses to that memory
location by the other threads become invalid.  Splat synchronizes with
the threads with the call:

wait_event_interruptible(ap.ap_waitq, splat_atomic_test1_cond(&ap, i));

Apparently, the SIGINT wakes and terminates splat prematurely, so that
GPFs or other bad things happen when the threads subsequently access ap.
This commit prevents this by using the uninterruptible form:

wait_event(ap.ap_waitq, splat_atomic_test1_cond(&ap, i));
This commit is contained in:
Ned Bass 2010-07-15 09:49:38 -07:00 committed by Brian Behlendorf
parent d0bd694ca9
commit 8f813bb168
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
module/splat/splat-atomic.c
View File

@ -165,7 +165,7 @@ splat_atomic_test1(struct file *file, void *arg)
schedule();
}
wait_event_interruptible(ap.ap_waitq, splat_atomic_test1_cond(&ap, i));
wait_event(ap.ap_waitq, splat_atomic_test1_cond(&ap, i));
if (rc) {
splat_vprint(file, SPLAT_ATOMIC_TEST1_NAME, "Only started "