Add `--enable=all` to ShellCheck by default

Change enforced shell type from `dash` to `sh` and excluded
`SC2039` and `SC3043` by default. `local` keyword is accepted by all
POSIX shells from practical point of view. There is no need anymore
to enforce dash so `local` is accepted.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: szubersk <szuberskidamian@gmail.com>
Closes #13020

cmd/Makefile.am

@@ -9,7 +9,6 @@ CPPCHECKDIRS += raidz_test zfs_ids_to_path zpool_influxdb
 
 # TODO: #12084: SHELLCHECKDIRS += vdev_id
 SHELLCHECKDIRS = fsck_zfs zed zpool zvol_wait
-SHELLCHECK_OPTS = --enable=all
 
 if USING_PYTHON
 SUBDIRS += arcstat arc_summary dbufstat

cmd/fsck_zfs/Makefile.am

@@ -5,4 +5,3 @@ dist_sbin_SCRIPTS = fsck.zfs
 
 SUBSTFILES += $(dist_sbin_SCRIPTS)
 
-SHELLCHECK_OPTS = --enable=all

cmd/zed/Makefile.am

@@ -5,7 +5,6 @@ AM_CFLAGS += $(LIBUDEV_CFLAGS) $(LIBUUID_CFLAGS)
 
 SUBDIRS = zed.d
 SHELLCHECKDIRS = $(SUBDIRS)
-SHELLCHECK_OPTS = --enable=all
 
 sbin_PROGRAMS = zed
 

cmd/zed/zed.d/Makefile.am

@@ -11,8 +11,7 @@ dist_zedconf_DATA = \
 	zed.rc
 
 SHELLCHECKSCRIPTS = zed-functions.sh zed.rc
-SHELLCHECK_OPTS = --enable=all
+SHELLCHECK_SHELL = sh
-SHELLCHECK_SHELL = dash
 
 zedexecdir = $(zfsexecdir)/zed.d
 

cmd/zpool/Makefile.am

@@ -5,7 +5,6 @@ AM_CFLAGS += $(LIBBLKID_CFLAGS) $(LIBUUID_CFLAGS)
 
 DEFAULT_INCLUDES += -I$(srcdir)
 
-SHELLCHECK_OPTS = --enable=all
 
 sbin_PROGRAMS = zpool
 

cmd/zvol_wait/Makefile.am

@@ -2,4 +2,3 @@ include $(top_srcdir)/config/Shellcheck.am
 
 dist_bin_SCRIPTS = zvol_wait
 
-SHELLCHECK_OPTS = --enable=all

config/Shellcheck.am

@@ -1,7 +1,15 @@
 .PHONY: shellcheck
 shellcheck: $(SCRIPTS) $(SHELLCHECKSCRIPTS)
+
+# ShellCheck exclusions
+#
+# ShellCheck can't follow non-constant source. Use a directive to specify location. [SC1090]
+# Not following: a was not specified as input (see shellcheck -x). [SC1091]
+# Prefer putting braces around variable references even when not strictly required. [SC2250]
+# In POSIX sh, 'local' is undefined. [SC2039] # older ShellCheck versions
+# In POSIX sh, 'local' is undefined. [SC3043] # newer ShellCheck versions
 if HAVE_SHELLCHECK
-	[ -z "$(SCRIPTS)$(SHELLCHECKSCRIPTS)" ] && exit; shellcheck --format=gcc --exclude=SC1090,SC1091,SC2250 $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") $(SHELLCHECK_OPTS) $(SCRIPTS) $(SHELLCHECKSCRIPTS)
+	[ -z "$(SCRIPTS)$(SHELLCHECKSCRIPTS)" ] && exit; shellcheck --format=gcc --enable=all --exclude=SC1090,SC1091,SC2039,SC2250,SC3043 $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") $(SHELLCHECK_OPTS) $(SCRIPTS) $(SHELLCHECKSCRIPTS)
 else
 	@[ -z "$(SCRIPTS)$(SHELLCHECKSCRIPTS)" ] && exit; echo "skipping shellcheck of" $(SCRIPTS) $(SHELLCHECKSCRIPTS) "because shellcheck is not installed"
 endif

contrib/Makefile.am

@@ -10,4 +10,3 @@ endif
 DIST_SUBDIRS = bash_completion.d bpftrace dracut initramfs pam_zfs_key pyzfs zcp
 
 SHELLCHECKDIRS = bash_completion.d bpftrace dracut initramfs
-SHELLCHECK_OPTS = --enable=all

contrib/bash_completion.d/Makefile.am

@@ -10,4 +10,3 @@ SUBSTFILES += $(noinst_DATA)
 
 SHELLCHECKSCRIPTS = $(noinst_DATA)
 SHELLCHECK_SHELL = bash
-SHELLCHECK_OPTS = --enable=all

contrib/bpftrace/Makefile.am

@@ -5,4 +5,3 @@ EXTRA_DIST = \
 	zfs-trace.sh
 
 SHELLCHECKSCRIPTS = zfs-trace.sh
-SHELLCHECK_OPTS = --enable=all

contrib/dracut/02zfsexpandknowledge/Makefile.am

@@ -5,5 +5,4 @@ pkgdracutdir = $(dracutdir)/modules.d/02zfsexpandknowledge
 pkgdracut_SCRIPTS = \
 	module-setup.sh
 
-SHELLCHECK_OPTS = --enable=all
 SUBSTFILES += $(pkgdracut_SCRIPTS)

contrib/dracut/90zfs/Makefile.am

@@ -19,7 +19,6 @@ pkgdracut_DATA = \
 	zfs-rollback-bootfs.service
 
 SUBSTFILES += $(pkgdracut_SCRIPTS) $(pkgdracut_DATA)
-SHELLCHECK_OPTS = --enable=all
 
 # Provided by /bin/sleep, and, again, every implementation of that supports this
 CHECKBASHISMS_IGNORE = -e 'sleep only takes one integer' -e 'sleep 0.'

contrib/initramfs/Makefile.am

@@ -7,7 +7,6 @@ dist_initrd_SCRIPTS = \
 
 SUBDIRS = conf.d conf-hooks.d hooks scripts
 SHELLCHECKDIRS = hooks scripts
-SHELLCHECK_OPTS = --enable=all
 
 EXTRA_DIST = \
 	README.initramfs.markdown

contrib/initramfs/hooks/Makefile.am

@@ -7,5 +7,4 @@ hooks_SCRIPTS = \
 	zfs \
 	zfsunlock
 
-SHELLCHECK_OPTS = --enable=all
 SUBSTFILES += $(hooks_SCRIPTS)

contrib/initramfs/scripts/Makefile.am

@@ -9,4 +9,3 @@ SUBDIRS = local-top
 
 SHELLCHECKDIRS = $(SUBDIRS)
 SHELLCHECK_SHELL = sh
-SHELLCHECK_OPTS = --enable=all

contrib/initramfs/scripts/local-top/Makefile.am

@@ -5,4 +5,3 @@ localtopdir = /usr/share/initramfs-tools/scripts/local-top
 dist_localtop_SCRIPTS = \
         zfs
 
-SHELLCHECK_OPTS = --enable=all

etc/Makefile.am

@@ -2,7 +2,6 @@ include $(top_srcdir)/config/Shellcheck.am
 
 SUBDIRS = zfs sudoers.d
 SHELLCHECKDIRS = default $(ZFS_INIT_SYSV) zfs
-SHELLCHECK_OPTS = --enable=all
 
 if BUILD_LINUX
 SUBDIRS += default $(ZFS_INIT_SYSTEMD) $(ZFS_INIT_SYSV) $(ZFS_MODULE_LOAD)

etc/default/Makefile.am

@@ -5,5 +5,4 @@ initconf_SCRIPTS = zfs
 
 SUBSTFILES += $(initconf_SCRIPTS)
 
-SHELLCHECK_SHELL = dash
+SHELLCHECK_SHELL = sh
-SHELLCHECK_OPTS = --enable=all

etc/init.d/Makefile.am

@@ -7,5 +7,4 @@ init_SCRIPTS = zfs-import zfs-load-key zfs-mount zfs-share zfs-zed
 
 SUBSTFILES += $(init_SCRIPTS)
 
-SHELLCHECK_SHELL = dash
+SHELLCHECK_SHELL = sh
-SHELLCHECK_OPTS = --enable=all

etc/zfs/Makefile.am

@@ -15,5 +15,4 @@ pkgsysconf_SCRIPTS = \
 
 SUBSTFILES += $(pkgsysconf_SCRIPTS)
 
-SHELLCHECK_OPTS = --enable=all
+SHELLCHECK_SHELL = sh
-SHELLCHECK_SHELL = dash

scripts/Makefile.am

@@ -28,7 +28,6 @@ EXTRA_DIST = \
 	$(EXTRA_SCRIPTS)
 
 SHELLCHECKSCRIPTS = $(EXTRA_SCRIPTS)
-SHELLCHECK_OPTS = --enable=all
 
 define EXTRA_ENVIRONMENT