Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

set_global_var() should not pass NULL pointers to dlclose() 

Both Coverity and Clang's static analyzer caught this.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14044
This commit is contained in:
Richard Yao 2022-10-16 00:56:55 -04:00 committed by Tony Hutter
parent 409c99a1d3
commit 89c41f3979
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/libzpool/util.c
View File

@ -228,13 +228,14 @@ set_global_var(char const *arg)
fprintf(stderr, "Failed to open libzpool.so to set global " fprintf(stderr, "Failed to open libzpool.so to set global "
"variable\n"); "variable\n");
ret = EIO; ret = EIO;
goto out_dlclose; goto out_free;
} }
ret = 0; ret = 0;
out_dlclose: out_dlclose:
dlclose(zpoolhdl); dlclose(zpoolhdl);
out_free:
free(varname); free(varname);
out_ret: out_ret:
return (ret); return (ret);