Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix two minor compiler warnings 

In cmd/splat.c there was a comparison between an __u32 and an int.  To
resolve the issue simply use a __u32 and strtoul() when converting the
provided user string.

In module/spl/spl-vnode.c we should explicitly cast nd->last.name to
a const char * which is what is expected by the prototype.
This commit is contained in:
Brian Behlendorf 2010-07-26 10:24:26 -07:00
parent 8b0eb3f0dc
commit 849c50e7f2
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cmd/splat.c
View File

@ -316,14 +316,15 @@ static test_t *test_find(char *sub_str, char *test_str)
ListIterator si, ti; ListIterator si, ti;
subsystem_t *sub; subsystem_t *sub;
test_t *test; test_t *test;
int sub_num, test_num; __u32 sub_num, test_num;
/* No error checking here because it may not be a number, it's /*
* No error checking here because it may not be a number, it's
* perfectly OK for it to be a string. Since we're just using * perfectly OK for it to be a string. Since we're just using
* it for comparison purposes this is all very safe. * it for comparison purposes this is all very safe.
*/ */
sub_num = strtol(sub_str, NULL, 0); sub_num = strtoul(sub_str, NULL, 0);
test_num = strtol(test_str, NULL, 0); test_num = strtoul(test_str, NULL, 0);
si = list_iterator_create(subsystems); si = list_iterator_create(subsystems);

3
module/spl/spl-vnode.c
View File

@ -257,7 +257,8 @@ EXPORT_SYMBOL(vn_seek);
static struct dentry * static struct dentry *
vn_lookup_hash(struct nameidata *nd) vn_lookup_hash(struct nameidata *nd)
{ {
return lookup_one_len(nd->last.name, nd->nd_dentry, nd->last.len); return lookup_one_len((const char *)nd->last.name,
nd->nd_dentry, nd->last.len);
} /* lookup_hash() */ } /* lookup_hash() */
static void static void