Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Minor `zstream redup` command fixes 

* Fix uninitialized variable in `zstream redup` command.  The
  'rdt.ddt_count' variable is uninitialized because it was
  allocated from the stack and not globally.  Initialize it.
  This was reported by gcc when compiling with debugging enabled.

    zstream_redup.c:157:16: error: 'rdt.ddt_count' may be used
    uninitialized in this function [-Werror=maybe-uninitialized]

* Remove the cmd/zstreamdump/.gitignore file.  It's no longer
  needed now that the zstreamdump command is a script.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #10192
This commit is contained in:
Brian Behlendorf 2020-04-10 21:10:09 -07:00 committed by GitHub
parent c618f87cd2
commit 8080848254
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/zstream/zstream_redup.c
View File

@ -218,6 +218,7 @@ zfs_redup_stream(int infd, int outfd, boolean_t verbose)
rdt.ddecache = umem_cache_create("rde", sizeof (redup_entry_t), 0, rdt.ddecache = umem_cache_create("rde", sizeof (redup_entry_t), 0,
NULL, NULL, NULL, NULL, NULL, 0); NULL, NULL, NULL, NULL, NULL, 0);
rdt.numhashbits = highbit64(numbuckets) - 1; rdt.numhashbits = highbit64(numbuckets) - 1;
rdt.ddt_count = 0;
char *buf = safe_calloc(bufsz); char *buf = safe_calloc(bufsz);
FILE *ofp = fdopen(infd, "r"); FILE *ofp = fdopen(infd, "r");

1
cmd/zstreamdump/.gitignore vendored
View File

@ -1 +0,0 @@
zstreamdump