From 7ceb9ad630f3cf4857a9fa2ad860d5990ff3f7c1 Mon Sep 17 00:00:00 2001 From: Mateusz Piotrowski <0mp@FreeBSD.org> Date: Mon, 3 Jun 2024 12:17:22 +0200 Subject: [PATCH] tests: user_property_001_pos: Remove unnecessary evals Reviewed-by: Tony Hutter Reviewed-by: Brian Behlendorf Reviewed-by: Alexander Motin Reviewed-by: Tino Reichardt Reviewed-by: Allan Jude Signed-off-by: Mateusz Piotrowski <0mp@FreeBSD.org> Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Closes #16248 --- .../functional/cli_root/zpool_set/user_property_001_pos.ksh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/zfs-tests/tests/functional/cli_root/zpool_set/user_property_001_pos.ksh b/tests/zfs-tests/tests/functional/cli_root/zpool_set/user_property_001_pos.ksh index 4b9097933f..ce8c78fa57 100755 --- a/tests/zfs-tests/tests/functional/cli_root/zpool_set/user_property_001_pos.ksh +++ b/tests/zfs-tests/tests/functional/cli_root/zpool_set/user_property_001_pos.ksh @@ -80,8 +80,8 @@ while ((i < ${#names[@]})); do typeset name="${names[$i]}" typeset value="${values[$i]}" - log_must eval "zpool set $name='$value' $TESTPOOL" - log_must eval "check_user_prop $TESTPOOL $name '$value'" + log_must zpool set "$name=$value" "$TESTPOOL" + log_must check_user_prop "$TESTPOOL" "$name" "$value" ((i += 1)) done