Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix NULL pointer dereference in zio_ready() 

Clang's static analyzer correctly identified a NULL pointer dereference
in zio_ready() when ZIO_FLAG_NODATA has been set on a zio that is
missing a block pointer. The NULL pointer dereference occurs because we
have logic intended to disable ZIO_FLAG_NODATA when it has been set on a
gang block.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14469
This commit is contained in:
Richard Yao 2023-02-23 13:19:08 -05:00 committed by GitHub
parent c9e39da9a4
commit 7cb67d627c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
module/zfs/zio.c
View File

@ -4431,7 +4431,7 @@ zio_ready(zio_t *zio)
} }
if (zio->io_flags & ZIO_FLAG_NODATA) { if (zio->io_flags & ZIO_FLAG_NODATA) {
if (BP_IS_GANG(bp)) { if (bp != NULL && BP_IS_GANG(bp)) {
zio->io_flags &= ~ZIO_FLAG_NODATA; zio->io_flags &= ~ZIO_FLAG_NODATA;
} else { } else {
ASSERT((uintptr_t)zio->io_abd < SPA_MAXBLOCKSIZE); ASSERT((uintptr_t)zio->io_abd < SPA_MAXBLOCKSIZE);