Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix coverity defects: CID 150926 

CID 150926: Unchecked return value (CHECKED_RETURN)
- This case cannot occur given the existing taskq implementation
  and flags passed to task_dispatch().

Reviewed-by: Chunwei Chen <david.chen@osnexus.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: luozhengzheng <luo.zhengzheng@zte.com.cn>
Closes #5272
This commit is contained in:
luozhengzheng 2016-10-19 02:32:59 +08:00 committed by Brian Behlendorf
parent 6d00b5e136
commit 7c502b0b1d
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
module/zfs/zfs_vnops.c
View File

@ -932,6 +932,12 @@ zfs_write(struct inode *ip, uio_t *uio, int ioflag, cred_t *cr)
} }
EXPORT_SYMBOL(zfs_write); EXPORT_SYMBOL(zfs_write);
/*
* Drop a reference on the passed inode asynchronously. This ensures
* that the caller will never drop the last reference on an inode in
* the current context. Doing so while holding open a tx could result
* in a deadlock if iput_final() re-enters the filesystem code.
*/
void void
zfs_iput_async(struct inode *ip) zfs_iput_async(struct inode *ip)
{ {
@ -941,8 +947,8 @@ zfs_iput_async(struct inode *ip)
ASSERT(os != NULL); ASSERT(os != NULL);
if (atomic_read(&ip->i_count) == 1) if (atomic_read(&ip->i_count) == 1)
taskq_dispatch(dsl_pool_iput_taskq(dmu_objset_pool(os)), VERIFY(taskq_dispatch(dsl_pool_iput_taskq(dmu_objset_pool(os)),
(task_func_t *)iput, ip, TQ_SLEEP); (task_func_t *)iput, ip, TQ_SLEEP) != 0);
else else
iput(ip); iput(ip);
} }