Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix gcc configure warnings 

Newer versions of gcc are getting smart enough to detect the sloppy
syntax used for the autoconf tests.  It is now generating warnings
for unused/undeclared variables.  Newer version of gcc even have
the -Wunused-but-set-variable option set by default.  This isn't a
problem except when -Werror is set and they get promoted to an error.
In this case the autoconf test will return an incorrect result which
will result in a build failure latter on.

To handle this I'm tightening up many of the autoconf tests to
explicitly mark variables as unused to suppress the gcc warning.
Remember, all of the autoconf code can never actually be run we
just want to get a clean build error to detect which APIs are
available.  Never using a variable is absolutely fine for this.

Closes #176
This commit is contained in:
Brian Behlendorf 2011-04-19 10:02:21 -07:00
parent 03514b0110
commit 79713039a2
10 changed files with 45 additions and 45 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/kernel-bio-end-io-t-args.m4
View File

@ -15,7 +15,7 @@ AC_DEFUN([ZFS_AC_KERNEL_BIO_END_IO_T_ARGS], [
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
void (*wanted_end_io)(struct bio *, int) = NULL; void (*wanted_end_io)(struct bio *, int) = NULL;
bio_end_io_t *local_end_io; bio_end_io_t *local_end_io __attribute__ ((unused));
local_end_io = wanted_end_io; local_end_io = wanted_end_io;
],[ ],[

6
config/kernel-bio-failfast.m4
View File

@ -9,7 +9,7 @@ AC_DEFUN([ZFS_AC_KERNEL_BIO_FAILFAST], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
int flags; int flags __attribute__ ((unused));
flags = (1 << BIO_RW_FAILFAST); flags = (1 << BIO_RW_FAILFAST);
],[ ],[
AC_MSG_RESULT(yes) AC_MSG_RESULT(yes)
@ -25,7 +25,7 @@ AC_DEFUN([ZFS_AC_KERNEL_BIO_FAILFAST_DTD], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
int flags; int flags __attribute__ ((unused));
flags = ((1 << BIO_RW_FAILFAST_DEV) | flags = ((1 << BIO_RW_FAILFAST_DEV) |
(1 << BIO_RW_FAILFAST_TRANSPORT) | (1 << BIO_RW_FAILFAST_TRANSPORT) |
(1 << BIO_RW_FAILFAST_DRIVER)); (1 << BIO_RW_FAILFAST_DRIVER));
@ -43,7 +43,7 @@ AC_DEFUN([ZFS_AC_KERNEL_REQ_FAILFAST_MASK], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
int flags; int flags __attribute__ ((unused));
flags = REQ_FAILFAST_MASK; flags = REQ_FAILFAST_MASK;
],[ ],[
AC_MSG_RESULT(yes) AC_MSG_RESULT(yes)

6
config/kernel-bio-rw-syncio.m4
View File

@ -9,7 +9,7 @@ AC_DEFUN([ZFS_AC_KERNEL_BIO_RW_SYNC], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
int flags; int flags __attribute__ ((unused));
flags = BIO_RW_SYNC; flags = BIO_RW_SYNC;
],[ ],[
AC_MSG_RESULT(yes) AC_MSG_RESULT(yes)
@ -24,7 +24,7 @@ AC_DEFUN([ZFS_AC_KERNEL_BIO_RW_SYNCIO], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
int flags; int flags __attribute__ ((unused));
flags = BIO_RW_SYNCIO; flags = BIO_RW_SYNCIO;
],[ ],[
AC_MSG_RESULT(yes) AC_MSG_RESULT(yes)
@ -39,7 +39,7 @@ AC_DEFUN([ZFS_AC_KERNEL_REQ_SYNC], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/bio.h> #include <linux/bio.h>
],[ ],[
int flags; int flags __attribute__ ((unused));
flags = REQ_SYNC; flags = REQ_SYNC;
],[ ],[
AC_MSG_RESULT(yes) AC_MSG_RESULT(yes)

2
config/kernel-evict-inode.m4
View File

@ -9,7 +9,7 @@ AC_DEFUN([ZFS_AC_KERNEL_EVICT_INODE], [
#include <linux/fs.h> #include <linux/fs.h>
],[ ],[
void (*evict_inode) (struct inode *) = NULL; void (*evict_inode) (struct inode *) = NULL;
struct super_operations sops; struct super_operations sops __attribute__ ((unused));
sops.evict_inode = evict_inode; sops.evict_inode = evict_inode;
],[ ],[

2
config/kernel-fmode-t.m4
View File

@ -7,7 +7,7 @@ AC_DEFUN([ZFS_AC_KERNEL_TYPE_FMODE_T],
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/types.h> #include <linux/types.h>
],[ ],[
fmode_t *ptr; fmode_t *ptr __attribute__ ((unused));
],[ ],[
AC_MSG_RESULT([yes]) AC_MSG_RESULT([yes])
AC_DEFINE(HAVE_FMODE_T, 1, AC_DEFINE(HAVE_FMODE_T, 1,

2
config/kernel-fsync.m4
View File

@ -8,7 +8,7 @@ AC_DEFUN([ZFS_AC_KERNEL_FSYNC_2ARGS], [
#include <linux/fs.h> #include <linux/fs.h>
],[ ],[
int (*fsync) (struct file *, int datasync) = NULL; int (*fsync) (struct file *, int datasync) = NULL;
struct file_operations fops; struct file_operations fops __attribute__ ((unused));
fops.fsync = fsync; fops.fsync = fsync;
],[ ],[

2
config/kernel-invalidate-bdev-args.m4
View File

@ -7,7 +7,7 @@ AC_DEFUN([ZFS_AC_KERNEL_INVALIDATE_BDEV_ARGS], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/buffer_head.h> #include <linux/buffer_head.h>
],[ ],[
struct block_device *bdev; struct block_device *bdev = NULL;
invalidate_bdev(bdev); invalidate_bdev(bdev);
],[ ],[
AC_MSG_RESULT(yes) AC_MSG_RESULT(yes)

2
config/kernel-kobj-name-len.m4
View File

@ -9,7 +9,7 @@ AC_DEFUN([ZFS_AC_KERNEL_KOBJ_NAME_LEN], [
ZFS_LINUX_TRY_COMPILE([ ZFS_LINUX_TRY_COMPILE([
#include <linux/kobject.h> #include <linux/kobject.h>
],[ ],[
int val; int val __attribute__ ((unused));
val = KOBJ_NAME_LEN; val = KOBJ_NAME_LEN;
],[ ],[
AC_MSG_RESULT([yes]) AC_MSG_RESULT([yes])

6
config/kernel-xattr-handler.m4
View File

@ -19,7 +19,7 @@ AC_DEFUN([ZFS_AC_KERNEL_CONST_XATTR_HANDLER],
&xattr_test_handler, &xattr_test_handler,
}; };
],[ ],[
struct super_block sb; struct super_block sb __attribute__ ((unused));
sb.s_xattr = xattr_handlers; sb.s_xattr = xattr_handlers;
],[ ],[
@ -43,7 +43,7 @@ AC_DEFUN([ZFS_AC_KERNEL_XATTR_HANDLER_GET], [
],[ ],[
int (*get)(struct dentry *dentry, const char *name, int (*get)(struct dentry *dentry, const char *name,
void *buffer, size_t size, int handler_flags) = NULL; void *buffer, size_t size, int handler_flags) = NULL;
struct xattr_handler xops; struct xattr_handler xops __attribute__ ((unused));
xops.get = get; xops.get = get;
],[ ],[
@ -68,7 +68,7 @@ AC_DEFUN([ZFS_AC_KERNEL_XATTR_HANDLER_SET], [
int (*set)(struct dentry *dentry, const char *name, int (*set)(struct dentry *dentry, const char *name,
const void *buffer, size_t size, int flags, const void *buffer, size_t size, int flags,
int handler_flags) = NULL; int handler_flags) = NULL;
struct xattr_handler xops; struct xattr_handler xops __attribute__ ((unused));
xops.set = set; xops.set = set;
],[ ],[

60
configure vendored
View File

@ -12372,7 +12372,7 @@ int
main (void) main (void)
{ {
fmode_t *ptr; fmode_t *ptr __attribute__ ((unused));
; ;
return 0; return 0;
@ -12437,7 +12437,7 @@ int
main (void) main (void)
{ {
int val; int val __attribute__ ((unused));
val = KOBJ_NAME_LEN; val = KOBJ_NAME_LEN;
; ;
@ -12583,7 +12583,7 @@ int
main (void) main (void)
{ {
struct block_device *bdev; struct block_device *bdev = NULL;
invalidate_bdev(bdev); invalidate_bdev(bdev);
; ;
@ -12782,7 +12782,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = (1 << BIO_RW_FAILFAST); flags = (1 << BIO_RW_FAILFAST);
; ;
@ -12848,7 +12848,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = ((1 << BIO_RW_FAILFAST_DEV) | flags = ((1 << BIO_RW_FAILFAST_DEV) |
(1 << BIO_RW_FAILFAST_TRANSPORT) | (1 << BIO_RW_FAILFAST_TRANSPORT) |
(1 << BIO_RW_FAILFAST_DRIVER)); (1 << BIO_RW_FAILFAST_DRIVER));
@ -12916,7 +12916,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = REQ_FAILFAST_MASK; flags = REQ_FAILFAST_MASK;
; ;
@ -12985,7 +12985,7 @@ main (void)
{ {
void (*wanted_end_io)(struct bio *, int) = NULL; void (*wanted_end_io)(struct bio *, int) = NULL;
bio_end_io_t *local_end_io; bio_end_io_t *local_end_io __attribute__ ((unused));
local_end_io = wanted_end_io; local_end_io = wanted_end_io;
@ -13053,7 +13053,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = BIO_RW_SYNC; flags = BIO_RW_SYNC;
; ;
@ -13119,7 +13119,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = BIO_RW_SYNCIO; flags = BIO_RW_SYNCIO;
; ;
@ -13185,7 +13185,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = REQ_SYNC; flags = REQ_SYNC;
; ;
@ -13994,7 +13994,7 @@ int
main (void) main (void)
{ {
struct super_block sb; struct super_block sb __attribute__ ((unused));
sb.s_xattr = xattr_handlers; sb.s_xattr = xattr_handlers;
@ -14063,7 +14063,7 @@ main (void)
int (*get)(struct dentry *dentry, const char *name, int (*get)(struct dentry *dentry, const char *name,
void *buffer, size_t size, int handler_flags) = NULL; void *buffer, size_t size, int handler_flags) = NULL;
struct xattr_handler xops; struct xattr_handler xops __attribute__ ((unused));
xops.get = get; xops.get = get;
@ -14133,7 +14133,7 @@ main (void)
int (*set)(struct dentry *dentry, const char *name, int (*set)(struct dentry *dentry, const char *name,
const void *buffer, size_t size, int flags, const void *buffer, size_t size, int flags,
int handler_flags) = NULL; int handler_flags) = NULL;
struct xattr_handler xops; struct xattr_handler xops __attribute__ ((unused));
xops.set = set; xops.set = set;
@ -14201,7 +14201,7 @@ main (void)
{ {
int (*fsync) (struct file *, int datasync) = NULL; int (*fsync) (struct file *, int datasync) = NULL;
struct file_operations fops; struct file_operations fops __attribute__ ((unused));
fops.fsync = fsync; fops.fsync = fsync;
@ -14269,7 +14269,7 @@ main (void)
{ {
void (*evict_inode) (struct inode *) = NULL; void (*evict_inode) (struct inode *) = NULL;
struct super_operations sops; struct super_operations sops __attribute__ ((unused));
sops.evict_inode = evict_inode; sops.evict_inode = evict_inode;
@ -16417,7 +16417,7 @@ int
main (void) main (void)
{ {
fmode_t *ptr; fmode_t *ptr __attribute__ ((unused));
; ;
return 0; return 0;
@ -16482,7 +16482,7 @@ int
main (void) main (void)
{ {
int val; int val __attribute__ ((unused));
val = KOBJ_NAME_LEN; val = KOBJ_NAME_LEN;
; ;
@ -16628,7 +16628,7 @@ int
main (void) main (void)
{ {
struct block_device *bdev; struct block_device *bdev = NULL;
invalidate_bdev(bdev); invalidate_bdev(bdev);
; ;
@ -16827,7 +16827,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = (1 << BIO_RW_FAILFAST); flags = (1 << BIO_RW_FAILFAST);
; ;
@ -16893,7 +16893,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = ((1 << BIO_RW_FAILFAST_DEV) | flags = ((1 << BIO_RW_FAILFAST_DEV) |
(1 << BIO_RW_FAILFAST_TRANSPORT) | (1 << BIO_RW_FAILFAST_TRANSPORT) |
(1 << BIO_RW_FAILFAST_DRIVER)); (1 << BIO_RW_FAILFAST_DRIVER));
@ -16961,7 +16961,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = REQ_FAILFAST_MASK; flags = REQ_FAILFAST_MASK;
; ;
@ -17030,7 +17030,7 @@ main (void)
{ {
void (*wanted_end_io)(struct bio *, int) = NULL; void (*wanted_end_io)(struct bio *, int) = NULL;
bio_end_io_t *local_end_io; bio_end_io_t *local_end_io __attribute__ ((unused));
local_end_io = wanted_end_io; local_end_io = wanted_end_io;
@ -17098,7 +17098,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = BIO_RW_SYNC; flags = BIO_RW_SYNC;
; ;
@ -17164,7 +17164,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = BIO_RW_SYNCIO; flags = BIO_RW_SYNCIO;
; ;
@ -17230,7 +17230,7 @@ int
main (void) main (void)
{ {
int flags; int flags __attribute__ ((unused));
flags = REQ_SYNC; flags = REQ_SYNC;
; ;
@ -18039,7 +18039,7 @@ int
main (void) main (void)
{ {
struct super_block sb; struct super_block sb __attribute__ ((unused));
sb.s_xattr = xattr_handlers; sb.s_xattr = xattr_handlers;
@ -18108,7 +18108,7 @@ main (void)
int (*get)(struct dentry *dentry, const char *name, int (*get)(struct dentry *dentry, const char *name,
void *buffer, size_t size, int handler_flags) = NULL; void *buffer, size_t size, int handler_flags) = NULL;
struct xattr_handler xops; struct xattr_handler xops __attribute__ ((unused));
xops.get = get; xops.get = get;
@ -18178,7 +18178,7 @@ main (void)
int (*set)(struct dentry *dentry, const char *name, int (*set)(struct dentry *dentry, const char *name,
const void *buffer, size_t size, int flags, const void *buffer, size_t size, int flags,
int handler_flags) = NULL; int handler_flags) = NULL;
struct xattr_handler xops; struct xattr_handler xops __attribute__ ((unused));
xops.set = set; xops.set = set;
@ -18246,7 +18246,7 @@ main (void)
{ {
int (*fsync) (struct file *, int datasync) = NULL; int (*fsync) (struct file *, int datasync) = NULL;
struct file_operations fops; struct file_operations fops __attribute__ ((unused));
fops.fsync = fsync; fops.fsync = fsync;
@ -18314,7 +18314,7 @@ main (void)
{ {
void (*evict_inode) (struct inode *) = NULL; void (*evict_inode) (struct inode *) = NULL;
struct super_operations sops; struct super_operations sops __attribute__ ((unused));
sops.evict_inode = evict_inode; sops.evict_inode = evict_inode;