Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Remove list_size struct member from list implementation 

Removed the list_size struct member as it was only used in a single
assertion, as mentioned in PR #15478.

Reviewed-by: Brian Atkinson <batkinson@lanl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: MigeljanImeri <imerimigel@gmail.com>
Closes #15812
This commit is contained in:
MigeljanImeri 2024-01-26 15:46:42 -07:00 committed by GitHub
parent 884a48d991
commit 78e8c1f844
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/os/freebsd/spl/sys/list_impl.h
View File

@ -39,7 +39,6 @@ struct list_node {
}; };
struct list { struct list {
size_t list_size;
size_t list_offset; size_t list_offset;
struct list_node list_head; struct list_node list_head;
}; };

4
include/os/linux/spl/sys/list.h
View File

@ -48,7 +48,6 @@
typedef struct list_head list_node_t; typedef struct list_head list_node_t;
typedef struct list { typedef struct list {
size_t list_size;
size_t list_offset; size_t list_offset;
list_node_t list_head; list_node_t list_head;
} list_t; } list_t;
@ -72,7 +71,8 @@ list_link_init(list_node_t *node)
static inline void static inline void
list_create(list_t *list, size_t size, size_t offset) list_create(list_t *list, size_t size, size_t offset)
{ {
list->list_size = size; (void) size;
list->list_offset = offset; list->list_offset = offset;
INIT_LIST_HEAD(&list->list_head); INIT_LIST_HEAD(&list->list_head);
} }

1
lib/libspl/include/sys/list_impl.h
View File

@ -39,7 +39,6 @@ struct list_node {
}; };
struct list { struct list {
size_t list_size;
size_t list_offset; size_t list_offset;
struct list_node list_head; struct list_node list_head;
}; };

4
lib/libspl/list.c
View File

@ -65,7 +65,8 @@ list_create(list_t *list, size_t size, size_t offset)
ASSERT(size > 0); ASSERT(size > 0);
ASSERT(size >= offset + sizeof (list_node_t)); ASSERT(size >= offset + sizeof (list_node_t));
list->list_size = size; (void) size;
list->list_offset = offset; list->list_offset = offset;
list->list_head.next = list->list_head.prev = &list->list_head; list->list_head.next = list->list_head.prev = &list->list_head;
} }
@ -194,7 +195,6 @@ list_move_tail(list_t *dst, list_t *src)
list_node_t *dstnode = &dst->list_head; list_node_t *dstnode = &dst->list_head;
list_node_t *srcnode = &src->list_head; list_node_t *srcnode = &src->list_head;
ASSERT(dst->list_size == src->list_size);
ASSERT(dst->list_offset == src->list_offset); ASSERT(dst->list_offset == src->list_offset);
if (list_empty(src)) if (list_empty(src))

4
module/os/freebsd/spl/list.c
View File

@ -64,7 +64,8 @@ list_create(list_t *list, size_t size, size_t offset)
ASSERT3P(list, !=, NULL); ASSERT3P(list, !=, NULL);
ASSERT3U(size, >=, offset + sizeof (list_node_t)); ASSERT3U(size, >=, offset + sizeof (list_node_t));
list->list_size = size; (void) size;
list->list_offset = offset; list->list_offset = offset;
list->list_head.list_next = list->list_head.list_prev = list->list_head.list_next = list->list_head.list_prev =
&list->list_head; &list->list_head;
@ -194,7 +195,6 @@ list_move_tail(list_t *dst, list_t *src)
list_node_t *dstnode = &dst->list_head; list_node_t *dstnode = &dst->list_head;
list_node_t *srcnode = &src->list_head; list_node_t *srcnode = &src->list_head;
ASSERT3U(dst->list_size, ==, src->list_size);
ASSERT3U(dst->list_offset, ==, src->list_offset); ASSERT3U(dst->list_offset, ==, src->list_offset);
if (list_empty(src)) if (list_empty(src))