From 87d7387f6297c29cb532988f96998d231cabd5a4 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Fri, 16 Jan 2009 13:56:14 -0800 Subject: [PATCH] Minor fixes --- scripts/zpios-profile/zpios-profile-disk.sh | 3 ++- scripts/zpios-profile/zpios-profile-pids.sh | 3 ++- scripts/zpios-profile/zpios-profile-post.sh | 6 +++--- scripts/zpios-profile/zpios-profile-pre.sh | 6 +++--- scripts/zpios-profile/zpios-profile.sh | 4 +++- scripts/zpios-test/small.cfg | 2 +- scripts/zpios.sh | 10 +++++----- 7 files changed, 19 insertions(+), 15 deletions(-) diff --git a/scripts/zpios-profile/zpios-profile-disk.sh b/scripts/zpios-profile/zpios-profile-disk.sh index 38607a5492..b56ee1ee40 100755 --- a/scripts/zpios-profile/zpios-profile-disk.sh +++ b/scripts/zpios-profile/zpios-profile-disk.sh @@ -1,5 +1,4 @@ #!/bin/bash -# profile-zpios-disk.sh # # /proc/diskinfo # Field 1 -- device name @@ -15,6 +14,8 @@ # Field 11 -- # of milliseconds spent doing I/Os # Field 12 -- weighted # of milliseconds spent doing I/Os +PROG=zpios-profile-disk.sh + RUN_PIDS=${0} RUN_LOG_DIR=${1} RUN_ID=${2} diff --git a/scripts/zpios-profile/zpios-profile-pids.sh b/scripts/zpios-profile/zpios-profile-pids.sh index 22779dc194..3514b38e2a 100755 --- a/scripts/zpios-profile/zpios-profile-pids.sh +++ b/scripts/zpios-profile/zpios-profile-pids.sh @@ -1,5 +1,6 @@ #!/bin/bash -# profile-zpios-pids.sh + +PROG=zpios-profile-pids.sh RUN_PIDS=${0} RUN_LOG_DIR=${1} diff --git a/scripts/zpios-profile/zpios-profile-post.sh b/scripts/zpios-profile/zpios-profile-post.sh index 8f770f3819..0f2d59b0bb 100755 --- a/scripts/zpios-profile/zpios-profile-post.sh +++ b/scripts/zpios-profile/zpios-profile-post.sh @@ -1,7 +1,7 @@ #!/bin/bash -prog=profile-zpios-post.sh . ../.script-config +PROG=zpios-profile-post.sh RUN_POST=${0} RUN_PHASE=${1} @@ -19,10 +19,10 @@ RUN_THREAD_DELAY=${12} RUN_FLAGS=${13} RUN_RESULT=${14} -PROFILE_ZPIOS_PIDS_BIN=${TOPDIR}/scripts/profile-zpios-pids.sh +PROFILE_ZPIOS_PIDS_BIN=${TOPDIR}/scripts/zpios-profile/zpios-profile-pids.sh PROFILE_ZPIOS_PIDS_LOG=${RUN_LOG_DIR}/${RUN_ID}/pids-summary.csv -PROFILE_ZPIOS_DISK_BIN=${TOPDIR}/scripts/profile-zpios-disk.sh +PROFILE_ZPIOS_DISK_BIN=${TOPDIR}/scripts/zpios-/profile/zpios-profile-disk.sh PROFILE_ZPIOS_DISK_LOG=${RUN_LOG_DIR}/${RUN_ID}/disk-summary.csv PROFILE_ZPIOS_ARC_LOG=${RUN_LOG_DIR}/${RUN_ID}/arcstats diff --git a/scripts/zpios-profile/zpios-profile-pre.sh b/scripts/zpios-profile/zpios-profile-pre.sh index 64801d3bf7..2d6d1be2dd 100755 --- a/scripts/zpios-profile/zpios-profile-pre.sh +++ b/scripts/zpios-profile/zpios-profile-pre.sh @@ -1,7 +1,7 @@ #!/bin/bash -prog=profile-zpios-pre.sh -. ../.script-config +. ../common.sh +PROG=zpios-profile-pre.sh trap "PROFILE_ZPIOS_READY=1" SIGHUP @@ -21,7 +21,7 @@ RUN_THREAD_DELAY=${12} RUN_FLAGS=${13} RUN_RESULT=${14} -PROFILE_ZPIOS_BIN=${IOPDIR}/scripts/profile-zpios.sh +PROFILE_ZPIOS_BIN=${IOPDIR}/scripts/zpios-profile/zpios-profile.sh PROFILE_ZPIOS_READY=0 OPROFILE_LOG=${RUN_LOG_DIR}/${RUN_ID}/oprofile.txt diff --git a/scripts/zpios-profile/zpios-profile.sh b/scripts/zpios-profile/zpios-profile.sh index fe4fc3cd35..d3ff779eac 100755 --- a/scripts/zpios-profile/zpios-profile.sh +++ b/scripts/zpios-profile/zpios-profile.sh @@ -1,5 +1,7 @@ #!/bin/bash -# profile-zpios.sh + + +PROG=zpios-profile.sh trap "RUN_DONE=1" SIGHUP diff --git a/scripts/zpios-test/small.cfg b/scripts/zpios-test/small.cfg index 3e2d0d8454..35dbf016df 100755 --- a/scripts/zpios-test/small.cfg +++ b/scripts/zpios-test/small.cfg @@ -47,4 +47,4 @@ ZPIOS_CMD="${CMDDIR}/zpios/zpios \ --cleanup \ --verbose \ --human-readable \ - ${ZPIOS_OPTIONS} + ${ZPIOS_OPTIONS}" diff --git a/scripts/zpios.sh b/scripts/zpios.sh index 57c90ba750..aca22026b8 100755 --- a/scripts/zpios.sh +++ b/scripts/zpios.sh @@ -6,8 +6,9 @@ . ./common.sh PROG=zpios.sh -PROFILE_ZPIOS_PRE=${TOPDIR}/scripts/profile-zpios-pre.sh -PROFILE_ZPIOS_POST=${TOPDIR}/scripts/profile-zpios-post.sh +PROFILE_ZPIOS_PRE=${TOPDIR}/scripts/zpios-profile/zpios-profile-pre.sh +PROFILE_ZPIOS_POST=${TOPDIR}/scripts/zpios-profile/zpios-profile-post.sh +PROFILE_ZPIOS_LOG=/tmp/ MODULES=( \ ${MODDIR}/zpios/zpios.ko \ @@ -25,7 +26,7 @@ OPTIONS: -h Show this message -v Verbose -p Enable profiling - -c Specify disk configuration + -c Zpool configuration EOF } @@ -153,7 +154,6 @@ if check_modules; then fi fi -msg "Waiting for /dev/zpios to come up..." while [ ! -c /dev/zpios ]; do sleep 1 done @@ -176,7 +176,7 @@ fi . ${ZPIOS_TEST} if [ $PROFILE ]; then - ZPIOS_CMD="${ZPIOS_CMD} --log=${PROFILE_ZPIOS_LOGS}" + ZPIOS_CMD="${ZPIOS_CMD} --log=${PROFILE_ZPIOS_LOG}" ZPIOS_CMD="${ZPIOS_CMD} --prerun=${PROFILE_ZPIOS_PRE}" ZPIOS_CMD="${ZPIOS_CMD} --postrun=${PROFILE_ZPIOS_POST}" fi