From 7454d2bb8d860bb49353c8b60dc980de82296f73 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Fri, 22 Jan 2021 15:03:56 -0800 Subject: [PATCH] cppcheck: zpool_main.c possible null pointer dereference Explicitly check for NULL to satisfy cppcheck that "val" can never be NULL when passed to printf(). This looks like a false positive since is_blank_str() can never take the false conditional branch when passed a NULL. But there's no harm in adding the extra check. Reviewed-by: Ryan Moeller Signed-off-by: Brian Behlendorf Closes #11508 --- cmd/zpool/zpool_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/zpool/zpool_main.c b/cmd/zpool/zpool_main.c index 3ac3728667..50adc0add6 100644 --- a/cmd/zpool/zpool_main.c +++ b/cmd/zpool/zpool_main.c @@ -2010,7 +2010,7 @@ zpool_print_cmd(vdev_cmd_data_list_t *vcdl, const char *pool, char *path) * Mark empty values with dashes to make output * awk-able. */ - if (is_blank_str(val)) + if (val == NULL || is_blank_str(val)) val = "-"; printf("%*s", vcdl->uniq_cols_width[j], val);