Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fix reading uninitialized variable in receive_read 

When zfs_file_read returns error, resid may be uninitialized.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Chunwei Chen <david.chen@nutanix.com>
Closes #14404
This commit is contained in:
Chunwei Chen 2023-01-20 11:49:56 -08:00 committed by GitHub
parent 63267f7f77
commit 71974946be
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
module/zfs/dmu_recv.c
View File

@ -1500,11 +1500,11 @@ receive_read(dmu_recv_cookie_t *drc, int len, void *buf)
(drc->drc_featureflags & DMU_BACKUP_FEATURE_RAW) != 0); (drc->drc_featureflags & DMU_BACKUP_FEATURE_RAW) != 0);
while (done < len) { while (done < len) {
ssize_t resid; ssize_t resid = len - done;
zfs_file_t *fp = drc->drc_fp; zfs_file_t *fp = drc->drc_fp;
int err = zfs_file_read(fp, (char *)buf + done, int err = zfs_file_read(fp, (char *)buf + done,
len - done, &resid); len - done, &resid);
if (resid == len - done) { if (err == 0 && resid == len - done) {
/* /*
* Note: ECKSUM or ZFS_ERR_STREAM_TRUNCATED indicates * Note: ECKSUM or ZFS_ERR_STREAM_TRUNCATED indicates
* that the receive was interrupted and can * that the receive was interrupted and can