Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Don't hard-code number of ioctls for portability 

Use (ZFS_IOC_LAST - ZFS_IOC_FIRST) instead of 256.
It seems 256 is just a number large enough to hold ioctls
at the moment.

Using 256 also causes compile-time warning or error
on platfoms whose enum zfs_ioc definition differs.

Reviewed-by: Olaf Faaland <faaland1@llnl.gov>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #8598
This commit is contained in:
Tomohiro Kusumi 2019-04-08 02:18:01 +09:00 committed by Brian Behlendorf
parent 96e51d2773
commit 703f791d35
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/zfs-tests/cmd/libzfs_input_check/libzfs_input_check.c
View File

@ -37,7 +37,7 @@ const char *active_test;
/* /*
* Tracks which zfs_ioc_t commands were tested * Tracks which zfs_ioc_t commands were tested
*/ */
boolean_t ioc_tested[256]; boolean_t ioc_tested[ZFS_IOC_LAST - ZFS_IOC_FIRST];
/* /*
* Legacy ioctls that are skipped (for now) * Legacy ioctls that are skipped (for now)