From 6a7c0ccca44ad02c476a111d8f7911fc8b12fff7 Mon Sep 17 00:00:00 2001 From: Brian Behlendorf Date: Thu, 22 Aug 2013 13:06:33 -0700 Subject: [PATCH] Use directory xattrs for symlinks There is currently a subtle bug in the SA implementation which can crop up which prevents us from safely using multiple variable length SAs in one object. Fortunately, the only existing use case for this are symlinks with SA based xattrs. Therefore, until the root cause in the SA code can be identified and fixed we prevent adding SA xattrs to symlinks. Signed-off-by: Brian Behlendorf Issue #1468 --- module/zfs/zpl_xattr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/module/zfs/zpl_xattr.c b/module/zfs/zpl_xattr.c index dca1ad6688..d79d35bce7 100644 --- a/module/zfs/zpl_xattr.c +++ b/module/zfs/zpl_xattr.c @@ -438,6 +438,10 @@ zpl_xattr_set_sa(struct inode *ip, const char *name, const void *value, if (error == -ENOENT) error = zpl_xattr_set_dir(ip, name, NULL, 0, flags, cr); } else { + /* Do not allow SA xattrs in symlinks (issue #1648) */ + if (S_ISLNK(ip->i_mode)) + return (-EMLINK); + /* Limited to 32k to keep nvpair memory allocations small */ if (size > DXATTR_MAX_ENTRY_SIZE) return (-EFBIG);