Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Make 1-bit bitfields unsigned 

This fixes -Wsingle-bit-bitfield-constant-conversion warning from
clang-16 like:

lib/libzfs/libzfs_dataset.c:4529:19: error: implicit truncation
  from 'int' to a one-bit wide bit-field changes value from
  1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
                flags.nounmount = B_TRUE;
				^ ~~~~~~

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Signed-off-by: Brooks Davis <brooks.davis@sri.com>
Closes #14125
This commit is contained in:
Brooks Davis 2022-11-01 20:43:32 +00:00 committed by Tony Hutter
parent 256b74d0b0
commit 572bd18c1f
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/libzfs.h
View File

@ -258,10 +258,10 @@ extern int zpool_add(zpool_handle_t *, nvlist_t *);
typedef struct splitflags { typedef struct splitflags {
/* do not split, but return the config that would be split off */ /* do not split, but return the config that would be split off */
int dryrun : 1; unsigned int dryrun : 1;
/* after splitting, import the pool */ /* after splitting, import the pool */
int import : 1; unsigned int import : 1;
int name_flags; int name_flags;
} splitflags_t; } splitflags_t;
@ -650,13 +650,13 @@ extern int zfs_rollback(zfs_handle_t *, zfs_handle_t *, boolean_t);
typedef struct renameflags { typedef struct renameflags {
/* recursive rename */ /* recursive rename */
int recursive : 1; unsigned int recursive : 1;
/* don't unmount file systems */ /* don't unmount file systems */
int nounmount : 1; unsigned int nounmount : 1;
/* force unmount file systems */ /* force unmount file systems */
int forceunmount : 1; unsigned int forceunmount : 1;
} renameflags_t; } renameflags_t;
extern int zfs_rename(zfs_handle_t *, const char *, renameflags_t); extern int zfs_rename(zfs_handle_t *, const char *, renameflags_t);

4
lib/libzfs/libzfs_pool.c
View File

@ -59,8 +59,8 @@
static boolean_t zpool_vdev_is_interior(const char *name); static boolean_t zpool_vdev_is_interior(const char *name);
typedef struct prop_flags { typedef struct prop_flags {
int create:1; /* Validate property on creation */ unsigned int create:1; /* Validate property on creation */
int import:1; /* Validate property on import */ unsigned int import:1; /* Validate property on import */
} prop_flags_t; } prop_flags_t;
/* /*