From 5600dff0ef56f3bef23356a1ea2ee2364a4c1139 Mon Sep 17 00:00:00 2001 From: Quartz Date: Tue, 27 Feb 2024 03:41:44 +0800 Subject: [PATCH] Fixed parameter passing error when calling zfs_acl_chmod Follow up to 99495ba6abbf0bb726324d03212c6f5ffa00043e which accidentally introduce this regression. Reviewed by: Brian Behlendorf Signed-off-by: Quartz Closes #15907 --- module/os/linux/zfs/zfs_acl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/module/os/linux/zfs/zfs_acl.c b/module/os/linux/zfs/zfs_acl.c index a1fd3c9856..48abbc0109 100644 --- a/module/os/linux/zfs/zfs_acl.c +++ b/module/os/linux/zfs/zfs_acl.c @@ -1921,8 +1921,8 @@ zfs_acl_ids_create(znode_t *dzp, int flag, vattr_t *vap, cred_t *cr, zfsvfs->z_acl_inherit != ZFS_ACL_PASSTHROUGH && zfsvfs->z_acl_inherit != ZFS_ACL_PASSTHROUGH_X) trim = B_TRUE; - zfs_acl_chmod(vap->va_mode, acl_ids->z_mode, B_FALSE, - trim, acl_ids->z_aclp); + zfs_acl_chmod(S_ISDIR(vap->va_mode), acl_ids->z_mode, + B_FALSE, trim, acl_ids->z_aclp); } }