From 4efb48eecb43717f70817bfb152bf86f7ed28b5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Neal=20Gompa=20=28=E3=83=8B=E3=83=BC=E3=83=AB=E3=83=BB?= =?UTF-8?q?=E3=82=B4=E3=83=B3=E3=83=91=29?= Date: Tue, 8 Jan 2019 12:23:05 -0500 Subject: [PATCH] Bump commit subject length to 72 characters There's not really a reason to keep the subject length so short, since the reason to make it this short was for making nice renders of a summary list of the git log. With 72 characters, this still works out fine, so let's just raise it to that so that it's easier to give slightly more descriptive change summaries. Reviewed by: Matt Ahrens Reviewed-by: Tony Hutter Reviewed-by: Brian Behlendorf Signed-off-by: Neal Gompa Closes #8250 --- .github/CONTRIBUTING.md | 2 +- scripts/commitcheck.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 32be3d4102..1bd17bd93f 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -164,7 +164,7 @@ coding convention. ### Commit Message Formats #### New Changes Commit messages for new changes must meet the following guidelines: -* In 50 characters or less, provide a summary of the change as the +* In 72 characters or less, provide a summary of the change as the first line in the commit message. * A body which provides a description of the change. If necessary, please summarize important information such as why the proposed diff --git a/scripts/commitcheck.sh b/scripts/commitcheck.sh index f377bb9128..2954b0fd72 100755 --- a/scripts/commitcheck.sh +++ b/scripts/commitcheck.sh @@ -69,10 +69,10 @@ function new_change_commit() { error=0 - # subject is not longer than 50 characters - long_subject=$(git log -n 1 --pretty=%s "$REF" | grep -E -m 1 '.{51}') + # subject is not longer than 72 characters + long_subject=$(git log -n 1 --pretty=%s "$REF" | grep -E -m 1 '.{73}') if [ -n "$long_subject" ]; then - echo "error: commit subject over 50 characters" + echo "error: commit subject over 72 characters" error=1 fi