Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

spa: add zio_taskq_trylock tuneable 

Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
This commit is contained in:
Rob Norris 2023-12-22 14:42:34 +11:00
parent 7d74fc7a68
commit 4e9cbd04a4
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
module/zfs/spa.c
View File

@ -173,6 +173,14 @@ uint_t zio_taskq_batch_tpq; /* threads per taskq */
boolean_t zio_taskq_sysdc = B_TRUE; /* use SDC scheduling class */ boolean_t zio_taskq_sysdc = B_TRUE; /* use SDC scheduling class */
uint_t zio_taskq_basedc = 80; /* base duty cycle */ uint_t zio_taskq_basedc = 80; /* base duty cycle */
/*
* If enabled, try to find an unlocked IO taskq to dispatch an IO onto before
* falling back to waiting on a lock. This should only be enabled in
* conjunction with careful performance testing, and will likely require
* zio_taskq_read/zio_taskq_write to be adjusted as well.
*/
boolean_t zio_taskq_trylock = B_FALSE;
boolean_t spa_create_process = B_TRUE; /* no process ==> no sysdc */ boolean_t spa_create_process = B_TRUE; /* no process ==> no sysdc */
/* /*
@ -1411,11 +1419,13 @@ spa_taskq_dispatch_ent(spa_t *spa, zio_type_t t, zio_taskq_type_t q,
} }
int select = ((uint64_t)gethrtime()) % tqs->stqs_count; int select = ((uint64_t)gethrtime()) % tqs->stqs_count;
for (int i = 0; i < tqs->stqs_count; i++) { if (zio_taskq_trylock) {
if (taskq_try_dispatch_ent( for (int i = 0; i < tqs->stqs_count; i++) {
tqs->stqs_taskq[select], func, arg, flags, ent)) if (taskq_try_dispatch_ent(
goto out; tqs->stqs_taskq[select], func, arg, flags, ent))
select = (select+1) % tqs->stqs_count; goto out;
select = (select+1) % tqs->stqs_count;
}
} }
taskq_dispatch_ent(tqs->stqs_taskq[select], func, arg, flags, ent); taskq_dispatch_ent(tqs->stqs_taskq[select], func, arg, flags, ent);
@ -10485,6 +10495,9 @@ ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_pct, UINT, ZMOD_RD,
ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_tpq, UINT, ZMOD_RD, ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_batch_tpq, UINT, ZMOD_RD,
"Number of threads per IO worker taskqueue"); "Number of threads per IO worker taskqueue");
ZFS_MODULE_PARAM(zfs_zio, zio_, taskq_trylock, UINT, ZMOD_RD,
"Try to dispatch IO to an unlocked IO taskqueue before sleeping");
ZFS_MODULE_PARAM(zfs, zfs_, max_missing_tvds, ULONG, ZMOD_RW, ZFS_MODULE_PARAM(zfs, zfs_, max_missing_tvds, ULONG, ZMOD_RW,
"Allow importing pool with up to this number of missing top-level " "Allow importing pool with up to this number of missing top-level "
"vdevs (in read-only mode)"); "vdevs (in read-only mode)");