From 4d04e41e4def222e454d05d77c3a93057c58f471 Mon Sep 17 00:00:00 2001 From: hpingfs <101400146+hpingfs@users.noreply.github.com> Date: Thu, 31 Mar 2022 06:40:31 +0800 Subject: [PATCH] zfs_ctldir: fix incorrect argument type of rw_destroy The argument type of rw_destroy is (krwlock_t *) while currently krwlock_t is passed in zfs_ctldir.c. This error is hidden because rw_destroy is defined as ((void) 0) in linux. But anyway, this mismatch should be fixed. Reviewed-by: Brian Behlendorf Signed-off-by: Ping Huang Closes #13272 --- module/os/linux/zfs/zfs_ctldir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/module/os/linux/zfs/zfs_ctldir.c b/module/os/linux/zfs/zfs_ctldir.c index f7e71461a3..7723b52563 100644 --- a/module/os/linux/zfs/zfs_ctldir.c +++ b/module/os/linux/zfs/zfs_ctldir.c @@ -162,7 +162,7 @@ zfsctl_snapshot_free(zfs_snapentry_t *se) zfs_refcount_destroy(&se->se_refcount); kmem_strfree(se->se_name); kmem_strfree(se->se_path); - rw_destroy(se->se_taskqid_lock); + rw_destroy(&se->se_taskqid_lock); kmem_free(se, sizeof (zfs_snapentry_t)); }