Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Race between zfs-share and zfs-mount services 

When a system boots the zfs-mount.service and the
zfs-share.service can start simultaneously. What may be
unclear is that sharing a filesystem will first mount
the filesystem if it's not already mounted. This means
that both service can race to mount the same fileystem.
This race can result in a SEGFAULT or EBUSY conditions.

This change explicitly defines the start ordering between the
two services such that the zfs-mount.service is solely
responsible for mounting filesystems eliminating the race
between "zfs mount -a" and "zfs share -a" commands.

Reviewed-by: Sebastien Roy <sebastien.roy@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: George Wilson <george.wilson@delphix.com>
Closes #9083
This commit is contained in:
George Wilson 2019-07-28 21:13:56 -04:00 committed by Brian Behlendorf
parent 693c1fc478
commit 453bb4791e
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
etc/systemd/system/zfs-share.service.in
View File

@ -5,6 +5,7 @@ After=nfs-server.service nfs-kernel-server.service
After=smb.service After=smb.service
Before=rpc-statd-notify.service Before=rpc-statd-notify.service
Wants=zfs-mount.service Wants=zfs-mount.service
After=zfs-mount.service
PartOf=nfs-server.service nfs-kernel-server.service PartOf=nfs-server.service nfs-kernel-server.service
PartOf=smb.service PartOf=smb.service