Archive-Team
/
zfs
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 103 Wiki Activity

Fedora 28: Fix misc bounds check compiler warnings 

Fix a bunch of truncation compiler warnings that show up
on Fedora 28 (GCC 8.0.1).

Reviewed-by: Giuseppe Di Natale <guss80@gmail.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #7368
Closes #7826
Closes #7830
This commit is contained in:
Joao Carlos Mendes Luis 2018-08-26 16:55:44 -03:00 committed by Tony Hutter
parent 4356dd23a9
commit 3ea1f7f193
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/libshare/smb.c
View File

@ -218,7 +218,7 @@ smb_enable_share_one(const char *sharename, const char *sharepath)
int rc; int rc;
/* Support ZFS share name regexp '[[:alnum:]_-.: ]' */ /* Support ZFS share name regexp '[[:alnum:]_-.: ]' */
strncpy(name, sharename, sizeof (name)); strlcpy(name, sharename, sizeof (name));
name [sizeof (name)-1] = '\0'; name [sizeof (name)-1] = '\0';
pos = name; pos = name;

2
module/icp/core/kcf_mech_tabs.c
View File

@ -321,7 +321,7 @@ kcf_create_mech_entry(kcf_ops_class_t class, char *mechname)
mutex_enter(&(me_tab[i].me_mutex)); mutex_enter(&(me_tab[i].me_mutex));
if (me_tab[i].me_name[0] == 0) { if (me_tab[i].me_name[0] == 0) {
/* Found an empty spot */ /* Found an empty spot */
(void) strncpy(me_tab[i].me_name, mechname, (void) strlcpy(me_tab[i].me_name, mechname,
CRYPTO_MAX_MECH_NAME); CRYPTO_MAX_MECH_NAME);
me_tab[i].me_name[CRYPTO_MAX_MECH_NAME-1] = '\0'; me_tab[i].me_name[CRYPTO_MAX_MECH_NAME-1] = '\0';
me_tab[i].me_mechid = KCF_MECHID(class, i); me_tab[i].me_mechid = KCF_MECHID(class, i);

2
tests/zfs-tests/tests/functional/ctime/ctime.c
View File

@ -155,7 +155,7 @@ do_link(const char *pfile)
return (-1); return (-1);
} }
strncpy(pfile_copy, pfile, sizeof (pfile_copy)); strncpy(pfile_copy, pfile, sizeof (pfile_copy)-1);
pfile_copy[sizeof (pfile_copy) - 1] = '\0'; pfile_copy[sizeof (pfile_copy) - 1] = '\0';
/* /*
* Figure out source file directory name, and create * Figure out source file directory name, and create